Export sandbox label constant (#216) by abkaskari · Pull Request #317 · kubernetes-sigs/agent-sandbox

abkaskari · 2026-02-14T01:14:58Z

This PR exports the sandbox label constant to avoid duplication between
the API and controller packages.

Previously, the sandbox label key was defined inside the controller,
which created a risk of contract drift between the API and its consumers.
This change moves the label definition to api/v1alpha1 and exports it
as SandboxNameHashLabel so it can be reused consistently across the
codebase.

No functional behavior is changed. This is purely a refactoring to
improve maintainability and ensure a single source of truth for the
sandbox label key.

Related to #216.

k8s-ci-robot · 2026-02-14T01:15:07Z

Hi @abkaskari. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2026-02-14T01:15:27Z

✅ Deploy Preview for agent-sandbox canceled.

Name	Link
🔨 Latest commit	`c5e619b`
🔍 Latest deploy log	https://app.netlify.com/projects/agent-sandbox/deploys/69a2bb2a1d346300083bbca3

vicentefb · 2026-02-14T01:19:21Z

Hello @abkaskari ! do you mind linking the correct issue in the description of the PR, thanks! Perhaps, #216 ?

vicentefb · 2026-02-14T01:21:36Z

controllers/sandbox_controller.go


 const (
-	sandboxLabel                = "agents.x-k8s.io/sandbox-name-hash"
+	//sandboxLabel                = "agents.x-k8s.io/sandbox-name-hash"


please remove this line

friendly ping

vicentefb · 2026-02-14T01:22:31Z

/ok-to-test

abkaskari · 2026-02-14T01:23:01Z

Hello @abkaskari ! do you mind linking the correct issue in the description of the PR, thanks! Perhaps, #216 ?

#216

vicentefb · 2026-02-23T06:41:06Z

controllers/sandbox_controller_test.go

 		},
 	}

+	for _, tc := range testCases {


There is a massive commented-out block of the old TestReconcilePod function. Please delete this entire commented block.

vicentefb · 2026-02-23T06:42:06Z

api/v1alpha1/sandbox_types.go

 }

 // +kubebuilder:object:root=true
-


revert this change please

vicentefb · 2026-02-23T06:42:33Z

api/v1alpha1/sandbox_types.go

 	// VolumeClaimTemplates is a list of claims that the sandbox pod is allowed to reference.
 	// Every claim in this list must have at least one matching access mode with a provisioner volume.
 	// +optional
-	// +kubebuilder:validation:Optional


why is this removed ? i believe it should be kept, please revert this change.

vicentefb · 2026-02-23T06:42:48Z

api/v1alpha1/sandbox_types.go


 // SandboxSpec defines the desired state of Sandbox
 type SandboxSpec struct {
-	// The following markers will use OpenAPI v3 schema to validate the value


revert this change please, it's not related to this PR.

vicentefb

The actual logic changes—moving the label into api/v1alpha1/sandbox_types.go and exporting it as SandboxNameHashLabel make sense and are exactly the DRY refactoring we needed to prevent contract drift between the controllers. I left some comments that need to be addressed.

I also noticed that the PR description seems to describe a completely different set of changes (e.g., "Ensure existing pods adopt labels", "Update annotations to reflect the latest PodTemplate values", etc.). Could you please update the PR description to accurately reflect the simple constant refactoring you actually did here as well as adding the issue number there ? In addition to this could you also update the PR title, to something Export sandbox label constant, we aren't fixing any pod label synchronization issues here.

Thanks!!

aditya-shantanu

Thanks for making this change.

k8s-ci-robot · 2026-02-23T17:03:43Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abkaskari, aditya-shantanu
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

natasha41575 · 2026-03-02T21:11:08Z

/lgtm

janetkuo · 2026-03-02T21:14:31Z

api/v1alpha1/sandbox_types.go

 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )

+const SandboxNameHashLabel = "agents.x-k8s.io/sandbox-name-hash"


Please update extensions/controllers/sandboxclaim_controller.go to reuse this exported label as well

Fix pod label synchronization issue (kubernetes-sigs#42)

0282213

k8s-ci-robot requested review from janetkuo and justinsb February 14, 2026 01:15

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 14, 2026

vicentefb reviewed Feb 14, 2026

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2026

abkaskari added 2 commits February 14, 2026 02:46

Apply gofmt fixes to sandbox_types.go

9173a76

tests: update to use exported SandboxNameHashLabel (kubernetes-sigs#216)

beeca1d

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2026

abkaskari added 2 commits February 14, 2026 03:26

Fix go formatting

4cb70b7

Fix go formatting hello

8fc39d3

abkaskari requested a review from vicentefb February 21, 2026 15:20

vicentefb reviewed Feb 23, 2026

View reviewed changes

api/v1alpha1/sandbox_types.go

}

// +kubebuilder:object:root=true

Copy link

Member

vicentefb Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this change please

vicentefb reviewed Feb 23, 2026

View reviewed changes

vicentefb suggested changes Feb 23, 2026

View reviewed changes

test: remove old commented TestReconcilePod block

b60da54

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 23, 2026

api: export SandboxNameHashLabel constant

6c2921e

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2026

abkaskari changed the title ~~Fix pod label synchronization issue (#42)~~ Export sandbox label constant (#216) Feb 23, 2026

chore: fix formatting

6c8378b

aditya-shantanu approved these changes Feb 23, 2026

View reviewed changes

cleanup: remove commented constant as requested in review

c5e619b

k8s-ci-robot assigned natasha41575 Mar 2, 2026

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2026

janetkuo reviewed Mar 2, 2026

View reviewed changes

janetkuo self-assigned this Mar 2, 2026

Conversation

abkaskari commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Feb 14, 2026

Uh oh!

netlify bot commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for agent-sandbox canceled.

Uh oh!

vicentefb commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vicentefb Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vicentefb Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

vicentefb commented Feb 14, 2026

Uh oh!

abkaskari commented Feb 14, 2026

Uh oh!

vicentefb Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

vicentefb Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

vicentefb Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

vicentefb Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

vicentefb left a comment

Choose a reason for hiding this comment

Uh oh!

aditya-shantanu left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Feb 23, 2026

Uh oh!

natasha41575 commented Mar 2, 2026

Uh oh!

janetkuo Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

abkaskari commented Feb 14, 2026 •

edited

Loading

netlify bot commented Feb 14, 2026 •

edited

Loading

vicentefb commented Feb 14, 2026 •

edited

Loading

vicentefb Feb 14, 2026 •

edited

Loading