fix(nb): fix default workspace volume name to match default configs #801
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t configs Signed-off-by: Mathis Marcotte <84033116+mathis-marcotte@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
google-oss-prow
bot
added
area/frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix to improve consistency in the default workspace volume name when creating a new Notebook.
I noticed that on initial load of the crud-web-apps/jupyter form, the default workspace volume name was "{notebook-name}-workspace".
But if you deleted that workspace volume, and then re-added a workspace volume to the Notebook you are creating, then the workspace volume name was "{notebook-name}-volume".
This PR is to FIX the default name of the workspace volume to always follow the same standard of "{notebook-name}-workspace" to match with the default configs.
Original PR here: kubeflow/kubeflow#7705