Skip to content

Conversation

@Al-Pragliola
Copy link
Contributor

@Al-Pragliola Al-Pragliola commented Feb 7, 2025

Description

In this PR, I added a GHA to check if the autogenerated code from the python client is up to date with the changes made to the openapi schema, so that we don't have divergences when trying to build the python client locally, as already discussed with @tarilabs and @lugi0.

example of failed run: https://github.com/kubeflow/model-registry/actions/runs/13198154981/job/36843945528

How Has This Been Tested?

on the CI

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

@Al-Pragliola
Copy link
Contributor Author

/cc @tarilabs @lugi0

@google-oss-prow google-oss-prow bot requested a review from tarilabs February 7, 2025 10:57
@google-oss-prow
Copy link

@Al-Pragliola: GitHub didn't allow me to request PR reviews from the following users: lugi0.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @tarilabs @lugi0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@lugi0 lugi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Al-Pragliola , why not adding it to the existing suite of test jobs to avoid proliferation of workflow files?

- "api/openapi/model-registry.yaml"

jobs:
check-autogen:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend moving this job here:

wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it makes perfect sense to include this in the Python testing workflow 🙏🏼

@tarilabs
Copy link
Member

thank @Al-Pragliola !

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lugi0, tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenny-s51 jenny-s51 mentioned this pull request Feb 10, 2025
7 tasks
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
@Al-Pragliola Al-Pragliola force-pushed the al-pragliola-add-gha-check-autogen branch from b1e0db7 to b223872 Compare February 10, 2025 16:14
@google-oss-prow google-oss-prow bot removed the lgtm label Feb 10, 2025
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot merged commit 8f9da8c into kubeflow:main Feb 10, 2025
2 checks passed
@Al-Pragliola Al-Pragliola deleted the al-pragliola-add-gha-check-autogen branch February 10, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants