-
Notifications
You must be signed in to change notification settings - Fork 151
feat(gha): added gha to check if python client autogen code is in sync #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gha): added gha to check if python client autogen code is in sync #771
Conversation
f5dba7c to
d9f97ae
Compare
|
@Al-Pragliola: GitHub didn't allow me to request PR reviews from the following users: lugi0. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
lugi0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
tarilabs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Al-Pragliola , why not adding it to the existing suite of test jobs to avoid proliferation of workflow files?
| - "api/openapi/model-registry.yaml" | ||
|
|
||
| jobs: | ||
| check-autogen: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend moving this job here:
| jobs: |
wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it makes perfect sense to include this in the Python testing workflow 🙏🏼
|
thank @Al-Pragliola ! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lugi0, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
b1e0db7 to
b223872
Compare
|
New changes are detected. LGTM label has been removed. |
Description
In this PR, I added a GHA to check if the autogenerated code from the python client is up to date with the changes made to the openapi schema, so that we don't have divergences when trying to build the python client locally, as already discussed with @tarilabs and @lugi0.
example of failed run: https://github.com/kubeflow/model-registry/actions/runs/13198154981/job/36843945528
How Has This Been Tested?
on the CI
Merge criteria:
DCOcheck)