feat(bff): add concurrency handling for catalog source config updates #2068
+77
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proper conflict detection and HTTP 409 response for concurrent updates to catalog source configs using Kubernetes resourceVersion. Changes: - Add concurrency test verifying resourceVersion is preserved through read-modify-write cycle - Add ErrCatalogSourceConflict sentinel error in repositories - Wrap K8s conflict errors in Create/Update/Delete operations - Add conflictResponse helper returning HTTP 409 - Handle conflict errors in all catalog source config handlers This ensures concurrent updates receive proper conflict errors instead of silently overwriting each other or returning 500 errors. Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
Contributor
|
/lgtm |
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proper conflict detection and HTTP 409 response for concurrent updates to catalog source configs using Kubernetes resourceVersion.
Changes:
This ensures concurrent updates receive proper conflict errors instead of silently overwriting each other or returning 500 errors.
How Has This Been Tested?
make build
Merge criteria:
DCOcheck)