Skip to content

Conversation

@ederign
Copy link
Member

@ederign ederign commented Jan 3, 2026

Probably it's a overlap with: #2032

Description

Adds multi-architecture (arm64/amd64) support for the Model Registry UI Docker images. This follows the pattern from #1790.

This PR closes #2057 and should be merged after #2056 (just to make sure we test if multi arch works with docker compose).

Changes

  • .github/workflows/build-and-push-ui-images.yml: Added QEMU setup, PLATFORMS env var, and platforms parameter to build-push-action
  • .github/workflows/build-and-push-ui-images-standalone.yml: Added QEMU setup, PLATFORMS env var, and platforms parameter to build-push-action
  • clients/ui/.env: Updated PLATFORM to linux/arm64,linux/amd64

Note: The .env change only affects local builds when using Makefile targets (make docker-buildx, make docker-buildx-standalone, make docker-buildx-federated). The GitHub Actions workflows define their own PLATFORMS env var directly in the workflow YAML files and do not use the .env file.

How Has This Been Tested?

  • Successfully built multi-arch images locally for both model-registry/ui and model-registry/ui-standalone>
  • Hoping for the best in GHA 🤞

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

Signed-off-by: Eder Ignatowicz <ignatowicz@gmail.com>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ederign. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign ederign changed the title feat(ui): add multi-arch Docker image support for arm64 and amd64 feat(ui): add multi-arch Docker image support for arm64 and amd64 on UI Images Jan 3, 2026
@tarilabs
Copy link
Member

tarilabs commented Jan 3, 2026

Can we not just simply use

So to align for all Container image production? 🤔

@ederign
Copy link
Member Author

ederign commented Jan 3, 2026

@tarilabs probably yes! I didn't catch up with all PR's, but I'll review #2032 as soon as possible and close this one.
/hold

@ederign
Copy link
Member Author

ederign commented Jan 5, 2026

Closed in favor of #2032

@ederign ederign closed this Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adds multi-architecture (arm64/amd64) support for the Model Registry UI Docker images.

3 participants