Skip to content

feat(catalog): substitute min/max values for named queries #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
google-oss-prow merged 1 commit into from
Jan 5, 2026
Merged

feat(catalog): substitute min/max values for named queries #2022

google-oss-prow merged 1 commit into from
Jan 5, 2026
+411 −5

Conversation

@pboyd
Copy link
Member

@pboyd pboyd commented Dec 17, 2025 •
edited
Loading

Description

Replace "min"/"max" string placeholders in named queries with actual numeric minimum/maximum values from filter options.

How Has This Been Tested?

Tested on a dev cluster and unit tests.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

@pboyd pboyd changed the title feat(catalog): substitue min/max values for named queries feat(catalog): substitute min/max values for named queries Dec 17, 2025
@pboyd
feat(catalog): substitute min/max values for named queries
2c95ee3 
Replace "min"/"max" string placeholders in named queries with actual
numeric minimum/maximum values from filter options.

Signed-off-by: Paul Boyd <paul@pboyd.io>
jonburdo
jonburdo approved these changes Jan 5, 2026
View reviewed changes
Copy link
Member

@jonburdo jonburdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 5, 2026
@pboyd
Copy link
Member Author

pboyd commented Jan 5, 2026

/approve

@google-oss-prow
Copy link

google-oss-prow bot commented Jan 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pboyd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit bf51eb5 into kubeflow:main Jan 5, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Al-Pragliola Al-Pragliola Awaiting requested review from Al-Pragliola

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

1 more reviewer

@jonburdo jonburdo jonburdo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jonburdo jonburdo

Labels

approved Area/Model Catalog lgtm size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pboyd @jonburdo