chore: Code cleanup from some leftover code#590
Merged
google-oss-prow[bot] merged 8 commits intokubeflow:mainfrom Feb 4, 2026
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
StefanoFioravanzo
force-pushed
the
cleanup/phase1-dead-code-removal
branch
from
760a1cf to
d91c171
Compare
Remove Dockerfile.rok and Dockerfile.rok.dev which were used for Arrikto's Rok storage integration. These files reference obsolete base images from gcr.io/arrikto-public and are no longer maintained. Part of the Kale 2.0 modernization effort to remove dead code. Signed-off-by: Stefano Fioravanzo <stefano.fioravanzo@gmail.com>
Remove the Rok-specific icon component that was part of the Arrikto Rok storage integration. The component was not imported or used anywhere in the codebase. Part of the Kale 2.0 modernization effort to remove dead code. Signed-off-by: Stefano Fioravanzo <stefano.fioravanzo@gmail.com>
Signed-off-by: Stefano Fioravanzo <stefano.fioravanzo@gmail.com>
- new_nb_function_template.jinja2 → nb_function_template.jinja2 - new_pipeline_template.jinja2 → pipeline_template.jinja2 - Update compiler.py references Signed-off-by: Stefano Fioravanzo <stefano.fioravanzo@gmail.com>
- Remove unused rokAvailable prop from IAnnotationInputProps interface in AnnotationInput.tsx (was declared but never used in component) - Remove commented-out rokError variable from widget.tsx Part of the Kale 2.0 modernization effort to remove dead code. Signed-off-by: Stefano Fioravanzo <stefano.fioravanzo@gmail.com>
- Remove compression-pipeline.py which depended on rok_common.cmdutils module that is not available without Rok integration - Update skeleton.py to remove Rok snapshot references from comments - Remove 'label:access-rok:true' from steps_defaults metadata in: - examples/serving/sklearn/iris.ipynb - examples/serving/xgboost/iris.ipynb Part of the Kale 2.0 modernization effort to remove dead code. Signed-off-by: Stefano Fioravanzo <stefano.fioravanzo@gmail.com>
Remove resources section links that specifically reference: - Arrikto's Rok storage integration - MiniKF-specific codelabs that may no longer be maintained - CNCF webinar from 2020 about MiniKF Keep the introduction blog post and KubeCon tutorials as they contain valuable general content about Kale's approach to notebook-to-pipeline conversion. Part of the Kale 2.0 modernization effort to update documentation. Signed-off-by: Stefano Fioravanzo <stefano.fioravanzo@gmail.com>
StefanoFioravanzo
force-pushed
the
cleanup/phase1-dead-code-removal
branch
from
d91c171 to
efc0221
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Dockerfile.rokandDockerfile.rok.devBrowseInRokBlue.tsxicon,rokAvailableprop,rokErrorvariablepipeline_template.jinja2(KFPv1), renamenew_*templates to remove prefixlabel:access-rok:truefrom serving examples, deletecompression-pipeline.pyContext
Rok was a proprietary data management platform from Arrikto. With Arrikto no longer maintaining Kale, this integration is dead code. Removing it simplifies the codebase for the 2.0 release.