Skip to content

chroe(frontend): Better CSS on Compile and upload button#575

Open
FAUST-BENCHOU wants to merge 3 commits intokubeflow:mainfrom
FAUST-BENCHOU:chore/button-css
Open

chroe(frontend): Better CSS on Compile and upload button#575
FAUST-BENCHOU wants to merge 3 commits intokubeflow:mainfrom
FAUST-BENCHOU:chore/button-css

Conversation

@FAUST-BENCHOU
Copy link

Close #562 (comment)

Before:
18b1e56b5710bb384b7d90c47b3c95ba

After:
55c941d1d268ebf9a6c4dc911499debf

Signed-off-by: zhoujinyu <2319109590@qq.com>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@jesuino jesuino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @FAUST-BENCHOU

Thanks for your contribution!

The change looks great for the text alignment. I was also expecting the breadcumb button size to keep a fixed size when the button is resized. This is what I see when I resize the panel:

Image

I was expecting to be of a fixed size (about 5%) and the floating menu to be on the right side as well, but I know that moving the menu is hard because it has absolute position.

Image

Signed-off-by: zhoujinyu <2319109590@qq.com>
@FAUST-BENCHOU
Copy link
Author

image image

now it can meet your needs @jesuino

@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Feb 3, 2026
Copy link
Collaborator

@jesuino jesuino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@google-oss-prow google-oss-prow bot added the lgtm label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug[frontend]: Better CSS on Compile and upload button

3 participants