feat(frontend): use notebook name as default pipeline name and handle TaskMissingError by cordeirops · Pull Request #524 · kubeflow/kale

cordeirops · 2025-11-19T22:39:06Z

feat: use notebook name as default pipeline name and handle TaskMissingError

Summary

This PR introduces improvements to pipeline name generation and error handling during notebook compilation.

Key Changes

Use the notebook filename as the default pipeline_name, applying sanitization to comply with KFP naming rules.
Add the domain exception TaskMissingError, raised by the compiler when a pipeline contains no steps.
Map TaskMissingError to RPCTaskIsMissing at the RPC layer and return a more actionable details message to the client.
Improve error handling in the notebook compilation flow to better guide users when pipeline steps are missing.
Add utility functions for pipeline name sanitization and default name derivation.
Frontend: implement default pipeline name + sanitization and provide a custom dialog for RPC error code 7 (TaskIsMissing).

StefanoFioravanzo · 2025-11-20T13:30:05Z

@cordeirops I took the liberty of updating the PR title and adding the issue link to the end of the firsts comment - in that way the PR and issue are linked

jesuino

Thanks for your contribution! The changes are looking good, I added some minor request changes.

I see you fixed two problems in the same PR and one of the problems seems to be missing a Github issue. I sugest you to create a PR per issue (1:1) and feel free to create issues when needed.

labextension/src/lib/RPCUtils.tsx

jesuino · 2026-01-06T17:19:07Z

labextension/src/lib/RPCUtils.tsx

+  ];
+  const result = await showDialog({ title, body, buttons });
+  const clicked = result.button ? (result.button.label as string) : '';
+  if (clicked === 'Open docs') {


We should avoid a hardcoded string and use a constant for this string

google-oss-prow · 2026-01-13T20:23:03Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cordeirops · 2026-01-13T20:37:07Z

Thanks for your contribution! The changes are looking good, I added some minor request changes.

I see you fixed two problems in the same PR and one of the problems seems to be missing a Github issue. I sugest you to create a PR per issue (1:1) and feel free to create issues when needed.

Hi @jesuino, thanks for the review. I’ve made the requested changes and committed them.

Regarding the two issues in the same PR, this is because in #507 there was a comment mentioning that it would be fixed by #510. For this reason, I updated the description of this PR to also reference #507.

jesuino

I can confirm that now a notebook comes with a default pipeline name:

Also there's a better error message when a notebook has no step:

ederign · 2026-01-16T21:16:23Z

@jesuino can you took another quick look here please?

jesuino

LGTM!

hmtosi

@cordeirops thank you for your work. There are quite a lot of changes here, so I have only reviewed the ones for the TaskMissingError so far. I believe there is a simpler way to do this, similar to what we did in #496. Please take a look at that solution, and at my comments.

hmtosi · 2026-01-29T23:58:49Z

backend/kale/errors.py

@@ -0,0 +1,14 @@
+"""Core domain exceptions for Kale (non-RPC).


It looks like the other error types are included in the rpc/errors.py file, without an entry in this file. I do not think we need to create a separate new errors.py file here, especially because the class only includes the pass keyword, and doesn't introduce other new functionality. Could you please delete this file?

hmtosi · 2026-01-29T23:59:35Z

backend/kale/rpc/nb.py

 from kale import Compiler, NotebookProcessor
-from kale.rpc.errors import RPCInternalError
+from kale.rpc.errors import RPCInternalError, RPCTaskIsMissing
+from kale.errors import TaskMissingError


The error type should remain the same, so the RPCTaskIsMissing import can be removed.
The from kale.errors import TaskMissingError line will not be needed, as this file should be deleted completely.

hmtosi · 2026-01-30T00:01:14Z

backend/kale/rpc/nb.py

+        return {"pipeline_package_path": os.path.relpath(package_path),
+                "pipeline_metadata": pipeline.config.to_dict()}
+    except TaskMissingError as e:
+        # Domain-specific exception raised by core components when no


Can you please clean up these comments to be more concise and descriptive of just the code? These explain a bit too much of the development process.

hmtosi · 2026-01-30T00:11:52Z

backend/kale/rpc/nb.py

+                              "compilation: %s", msg)
+        raise RPCTaskIsMissing(details=msg, trans_id=request.trans_id)
+    except ValueError as e:
+        # kfp.compiler or graph_component may


Please clean up these comments as well

hmtosi · 2026-02-02T17:04:13Z

backend/kale/rpc/nb.py

+
+        return {"pipeline_package_path": os.path.relpath(package_path),
+                "pipeline_metadata": pipeline.config.to_dict()}
+    except TaskMissingError as e:


Please use the RPCUnhandledError error instead of the TaskMissingError

hmtosi · 2026-02-02T18:19:00Z

backend/kale/rpc/errors.py

    INTERNAL_ERROR = 4
    SERVICE_UNAVAILABLE = 5
    UNHANDLED_ERROR = 6
+    TASK_IS_MISSING = 7


We should keep this as an UNHANDLED_ERROR, so this line of code will not be needed.

hmtosi · 2026-02-02T18:19:35Z

backend/kale/rpc/errors.py

    message = "Service is Unavailable"


+class RPCTaskIsMissing(_RPCError):


We can use the existing RPCUnhandledError, so we will not need this class

hmtosi · 2026-02-02T18:23:19Z

labextension/src/lib/RPCUtils.tsx

  }
 };

+const OPEN_DOCS_LABEL = 'Open docs';


Instead of opening the docs, I think it would be better to generate a clear error message asking the user to use the kale editor to tag the pipeline components. This way the user will not have to leave the page they are on. I believe we can remove this functionality.

hmtosi · 2026-02-02T18:25:51Z

labextension/src/lib/RPCUtils.tsx

-  refresh: boolean = false,
+  refresh: boolean = false
 ): Promise<void> => {
+  if (error && error.code === RPC_CALL_STATUS.TaskIsMissing) {


Please use the UnhandledError code instead of TaskIsMissing

hmtosi · 2026-02-02T18:27:47Z

labextension/src/lib/RPCUtils.tsx

    await showRpcError(this.error, refresh);
  }
 }
+


I believe this functionality can be simplified. There is some logic already for handling the UnhandledError messages (RPCUtils.tsx:13-58`) Instead of creating a new error type, I believe this function can be updated instead. I think it would be better to provide an error message directly in the pop-up that instructs the user on how to fix it, rather than directing them to the documentation. Please see #496 for a similar discussion.

ederign · 2026-02-03T19:57:45Z

@cordeirops sorry for the delay on the review of this one, we are cleaning the house. :)

Can you take a look on @hmtosi's comments?

cordeirops · 2026-02-03T20:34:08Z

@cordeirops sorry for the delay on the review of this one, we are cleaning the house. :)

Can you take a look on @hmtosi's comments?

@ederign No worries! Sure, I'll take a look at it.

review-notebook-app · 2026-02-04T17:29:08Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

- Introduced TaskMissingError to signal when a pipeline lacks steps. - Updated the compiler to raise TaskMissingError if no steps are present. - Mapped TaskMissingError to RPCTaskIsMissing for RPC error handling. - Enhanced error handling in the notebook compilation process to provide user guidance for missing steps. - Added utility functions in the UI to display informative dialogs for missing pipeline steps. Signed-off-by: cordeirops <pedro.sbarainicordeiro@gmail.com>

Signed-off-by: cordeirops <pedro.sbarainicordeiro@gmail.com>

Signed-off-by: Pedro Sbaraini Cordeiro <pedro.sbarainicordeiro@gmail.com>

Signed-off-by: cordeirops <pedro.sbarainicordeiro@gmail.com>

cordeirops · 2026-02-04T20:37:42Z

@hmtosi I’ve made the changes you requested.

When the pipeline does not contain any steps, the error is now displayed as shown below:

StefanoFioravanzo changed the title ~~FIX ISSUE_510~~ feat(frontend): use notebook name as default pipeline name and handle TaskMissingError Nov 20, 2025

jesuino requested review from StefanoFioravanzo, hmtosi and jesuino December 16, 2025 18:49

jesuino suggested changes Jan 6, 2026

View reviewed changes

google-oss-prow bot assigned jesuino Jan 6, 2026

google-oss-prow bot added the size/L label Jan 13, 2026

cordeirops requested a review from jesuino January 13, 2026 20:37

jesuino approved these changes Jan 15, 2026

View reviewed changes

google-oss-prow bot added lgtm and removed lgtm labels Jan 15, 2026

cordeirops force-pushed the issue510 branch from eec1777 to 146ab52 Compare January 16, 2026 19:30

ederign requested a review from jesuino January 16, 2026 21:16

jesuino approved these changes Jan 17, 2026

View reviewed changes

google-oss-prow bot added the lgtm label Jan 17, 2026

jesuino mentioned this pull request Jan 29, 2026

feature[backend]: Better notebook validation #560

Open

hmtosi suggested changes Feb 2, 2026

View reviewed changes

google-oss-prow bot assigned hmtosi Feb 2, 2026

google-oss-prow bot removed the lgtm label Feb 2, 2026

cordeirops force-pushed the issue510 branch from cca11ce to 6a9e434 Compare February 4, 2026 17:57

google-oss-prow bot added size/XXL and removed size/L size/XXL labels Feb 4, 2026

google-oss-prow bot added the size/L label Feb 4, 2026

cordeirops force-pushed the issue510 branch 2 times, most recently from b607237 to b62355e Compare February 4, 2026 18:36

cordeirops added 9 commits February 4, 2026 15:36

Fix code format

20bdb69

Signed-off-by: cordeirops <pedro.sbarainicordeiro@gmail.com>

Fix code format

5bffb89

Signed-off-by: cordeirops <pedro.sbarainicordeiro@gmail.com>

Fix lint check

89e56fd

Signed-off-by: cordeirops <pedro.sbarainicordeiro@gmail.com>

Fix lint check

4e0d523

Signed-off-by: cordeirops <pedro.sbarainicordeiro@gmail.com>

Fix issues pointed out by Jesuino

bf5e734

Signed-off-by: cordeirops <pedro.sbarainicordeiro@gmail.com>

Fix issues pointed out by Hannah

d95a5f8

Signed-off-by: cordeirops <pedro.sbarainicordeiro@gmail.com>

Fix backend lint and frontend syntax errors

49f230a

Signed-off-by: cordeirops <pedro.sbarainicordeiro@gmail.com>

FIx problems

8cbdb0f

Signed-off-by: cordeirops <pedro.sbarainicordeiro@gmail.com>

cordeirops force-pushed the issue510 branch from b62355e to 8cbdb0f Compare February 4, 2026 18:36

cordeirops added 3 commits February 4, 2026 15:39

Merge branch 'main' into issue510

7569c83

Signed-off-by: Pedro Sbaraini Cordeiro <pedro.sbarainicordeiro@gmail.com>

Add extension name retrieval for error notifications

feb29d5

Signed-off-by: cordeirops <pedro.sbarainicordeiro@gmail.com>

FIx lint errors

4e4d466

Signed-off-by: cordeirops <pedro.sbarainicordeiro@gmail.com>

cordeirops force-pushed the issue510 branch from e5e0ed8 to 4e4d466 Compare February 4, 2026 19:09

format backend with ruff

7dd496e

Signed-off-by: cordeirops <pedro.sbarainicordeiro@gmail.com>

cordeirops closed this Feb 4, 2026

cordeirops reopened this Feb 4, 2026

Merge branch 'main' into issue510

d0ce37a

		@@ -0,0 +1,14 @@
		"""Core domain exceptions for Kale (non-RPC).

		message = "Service is Unavailable"


		class RPCTaskIsMissing(_RPCError):

Conversation

cordeirops commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

feat: use notebook name as default pipeline name and handle TaskMissingError

Summary

Key Changes

Uh oh!

StefanoFioravanzo commented Nov 20, 2025

Uh oh!

jesuino left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-oss-prow bot commented Jan 13, 2026

Uh oh!

cordeirops commented Jan 13, 2026

Uh oh!

jesuino left a comment

Choose a reason for hiding this comment

Uh oh!

ederign commented Jan 16, 2026

Uh oh!

jesuino left a comment

Choose a reason for hiding this comment

Uh oh!

hmtosi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ederign commented Feb 3, 2026

Uh oh!

cordeirops commented Feb 3, 2026

Uh oh!

review-notebook-app bot commented Feb 4, 2026

Uh oh!

cordeirops commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cordeirops commented Nov 19, 2025 •

edited

Loading