-
Notifications
You must be signed in to change notification settings - Fork 177
use action/stale instead of probot/stale which has been deprecated. #747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
use action/stale instead of probot/stale which has been deprecated. #747
Conversation
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
Summary of ChangesHello @fujitatomoya, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses the issue of the repository's stale bot no longer functioning due to the deprecation of Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to replace the deprecated probot/stale with actions/stale. While it correctly removes the old configuration file .github/stale.yml, it appears to be missing the new GitHub Actions workflow file that would implement actions/stale. As it stands, this PR would remove the stale bot functionality entirely instead of replacing it. Please ensure the new workflow file is included in this pull request to achieve the intended goal.
I am having trouble creating individual review comments. Click here to see my feedback.
.github/stale.yml (1-52)
While removing this configuration file for the deprecated probot/stale is a necessary step, the pull request seems incomplete. The new GitHub Actions workflow file to enable actions/stale is missing. Without it, this PR only removes the stale bot functionality, contrary to its objective of replacing it. Please add the corresponding workflow file (e.g., in .github/workflows/stale.yml) to complete the migration.
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
fujitatomoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shelley-BaoYue @WillardHu what do you think about this? can you take a look?
CC: @kevin-wangzefeng as original author around this area.
Shelley-BaoYue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
It looks good to me, we can also make the same modification in other repos.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Shelley-BaoYue The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Which issue(s) this PR fixes:
Fixes #746
This replaces probot/stale which is not working anymore into action/stale with the same configuration.
Deprecated, stale workflow is not working anymore for a long time.
action/stale is online via workflow
No, only github workflow