Conversation
ampetz
approved these changes
Mar 3, 2026
Contributor
ampetz
left a comment
ampetz
left a comment
There was a problem hiding this comment.
Approving this, knowing there will be some further testing required to make sure it integrates with other upstream dependencies. We should figure out a way to test these before merging PRs in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support to the CVM for the changes in the Copland-Spec regarding the addition of the Type System.
In particular, the change in the Copland AST is supported, as well as the modifications to
ffin rocq-candy.Changes are also made with regard the ASP type signatures and the greater restrictions they place on ASP execution to ensure it is correct