Skip to content

Remove redundant access() check to eliminate TOCTOU vulnerability #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Durbatuluk1701 merged 2 commits into from
Feb 14, 2026
Merged

Remove redundant access() check to eliminate TOCTOU vulnerability #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
804e448
Initial plan
Copilot Feb 14, 2026
4a33b66
Remove redundant access() check to fix TOCTOU vulnerability
Copilot Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions stubs/FFI/sys_ffi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,16 +266,6 @@ void ffiexec_process_io(const char *commandIn, const long clen, char *a, const l
return;
}

// Verify the executable exists and is accessible
if (access(process_path, X_OK) != 0)
{
DEBUG_PRINTF("ffiexec_process_io: Process not found or not executable: %s (%s)\n",
process_path, strerror(errno));
free(process_path);
a[RESPONSE_CODE_START] = PATH_ERROR;
return;
}

// ---------- Create pipes ----------
int stdin_pipe[2]; // Parent writes to [1], child reads from [0]
int stdout_pipe[2]; // Child writes to [1], parent reads from [0]
Expand Down