Add conditional import for ByteReadChannel in MockEngine test code#44
Open
UnlikeMars wants to merge 1 commit intoktorio:mainfrom
Open
Add conditional import for ByteReadChannel in MockEngine test code#44UnlikeMars wants to merge 1 commit intoktorio:mainfrom
UnlikeMars wants to merge 1 commit intoktorio:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the test code generation imports
kotlinx.coroutines.experimental.io.*, required byByteReadChannelfor all Ktor versions. From ktor 1.3.0 the API changed andByteReadChannelis now located underio.ktor.utils.io.*. As a result, generated Ktor projects (version >= 1.3.0) using the Mock HttpClient Engine do not compile.This PR addresses #27 and points
ByteReadChannelto the correct import depending on the selected Ktor version.