-
Notifications
You must be signed in to change notification settings - Fork 9
[노유빈] 16주차 과제제출 #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[노유빈] 16주차 과제제출 #109
The head ref may contain hidden characters: "\uB178\uC720\uBE48-16\uC8FC\uCC28-\uACFC\uC81C\uC81C\uCD9C"
Conversation
donghoony
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다~! Approve 드릴게요! 조금 더 나은 코드를 위한 리뷰 드립니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a[i:i+2].isalpha()라는 함수로 해당 str가 알파벳으로만 이루어졌는지 확인할 수 있습니다. 그럼 m 배열도 필요없어요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
집합을 사용하고자 한다면 set을 사용하는 게 바람직합니다. 직접 하나하나 합/교집합을 구하지 않고, set 자체로 &(and) |(or) 연산을 통해 구할 수 있어요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
따로 a, b 원소를 변경하지 않으므로, 리스트에 담을 이유가 없어 보입니다. 그냥 str 형태로 해도 돼요!
donghoony
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추가 문제는 수정 후에 다시 리뷰드릴게요 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저는 이 문제를 보고 제일 먼저 BFS / DFS가 떠올랐어요. 격자판에서 상하좌우로 움직이며 빈 칸/벽을 찾아 채워나가는 데에는 BFS / DFS가 사용됩니다. 한 번 찾아서 적용해 보세요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import string
string.ascii_lowercase
를 사용하면 알파벳 소문자를 모두 불러올 수 있습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리스트에 추가하고 길이를 구할 수도 있지만 카운트하는 방법을 써도 될 것 같아요!
Grit03
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!! :)
16주차/(P)81302/(P)81302_python_노유빈.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
같은 구조의 반복문이 반복되는데 함수를 사용해서 나타내는 건 어떨까요?
16주차/(P)81302/(P)81302_python_노유빈.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one-five, one_p-five_p를 2차원 리스트로 나타내서 접근해도 괜찮을 것 같네요!
16주차/(P)81302/(P)81302_python_노유빈.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2차원 리스트로 만들고 BFS/DFS로 탐색을 하면서 확인해야 할 것 같네요 🤔
No description provided.