[강윤석] 17주차 과제 제출합니다 #106
Open
[강윤석] 17주차 과제 제출합니다 #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlawngP91
approved these changes
Jul 5, 2022
16주차/(P)17677/17677_js_강윤석.js
Outdated
Collaborator
There was a problem hiding this comment.
js는 '==' 와 '==='가 다르다는 것을 이번에 찾아보면서 또 배웠네요😊
16주차/(P)17677/17677_js_강윤석.js
Outdated
Collaborator
There was a problem hiding this comment.
반복문을 대신해서 reduce함수를 사용하고 이부분에서 string을 2개씩 나누는 거군요!
16주차/(P)17677/17677_js_강윤석.js
Outdated
Collaborator
There was a problem hiding this comment.
저는 2개씩 자른 영어문자열을 그냥 배열로 저장하고 모두 비교하는데 이렇게 map을 이용해서 같은 영어문자열은 중복해서 저장하지 않고 영어문자열을 key로 영어문자열의 개수는 value로 저장하는 방법도 좋은거 같습니다!
16주차/(P)81302/81302_js_강윤석.js
Outdated
Collaborator
There was a problem hiding this comment.
맨해튼 거리가 2보다 같거나 작은 경우를 각각 나누어서 정해놓고 코드를 짜니 훨씬 깔끔하고 보기 좋아요😊
16주차/(P)81302/81302_js_강윤석.js
Outdated
Collaborator
There was a problem hiding this comment.
맨해튼 거리가 1과 2인 경우 좌표가 유효한지 확인하고 1인경우는 바로 false를 리턴, 2인 경우는 위에서 정의했던 dx,dy값들을 이용해서 'X'인지 확인하니 코드가 정말 잘 이해됩니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.