Prefix most of the preprocessor macros with M68K_
#110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add prefixes to these preprocessor macros, so they’re properly namespaced like the rest of the preprocessor macros are: - `M68K_OPT_ON` - `M68K_OPT_OFF` - `M68K_OPT_SPECIFY_HANDLER` - `M68K_ARRAY_LENGTH` The `TRUE` and `FALSE` macros are kept as-is because they're so common in C codebases and they're already properly protected from redefinition.
Right now, users of Musashi generally need to incorporate it into their code, rather than just reference it, because it’s necessary to supply a custom `m68kconf.h` file for each use. By wrapping the preprocessor macros to control the options in `#ifdef` and `#endif`, these options can also be controlled without having to edit `m68kconf.h` while still having reasonable defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure ease of interoperability, I've prefixed almost all of the preprocessor macros used by Musashi with
M68K_since that's the common prefix in the public API. The only ones I've left alone areTRUEandFALSEandNULLsince those are so universal.I've also wrapped the preprocessor macros with
#ifdefand#endifso the contents of m68kconf.h can be selectively overridden, meaning those using Musashi don't need to incorporate and change it or write their own from scratch and replace it.