Add Arkveld encounter triggers and update version #220
Conversation
…Wilds encounter - Created arkveld.ts to define triggers and localization for the Guardian Arkveld fight. - Added arkveld.txt containing detailed timeline and mechanics for the encounter. - Included translations for ability names and mechanics in Chinese.
There was a problem hiding this comment.
Pull request overview
This pull request adds support for the Guardian Arkveld trial encounter from FFXIV Dawntrail, including both normal and extreme versions. It also updates the project version to 99.171.0 and adds Chinese localizations to several deep dungeon encounter files.
Key Changes:
- New timeline and trigger files for Arkveld normal and extreme trials
- Version bump to 99.171.0 across all project files
- Chinese (cn) localization additions for Pilgrim's Traverse deep dungeon encounters
- Visual Studio path update in build script
Reviewed changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/raidboss/data/07-dt/trial/arkveld.txt | New timeline file for normal Arkveld trial with detailed ability tracking and timing |
| ui/raidboss/data/07-dt/trial/arkveld.ts | New TypeScript trigger file with Chinese localization for Arkveld normal |
| ui/raidboss/data/07-dt/trial/arkveld-ex.txt | Extensive timeline for extreme Arkveld with multiple mechanics and patterns |
| ui/raidboss/data/07-dt/trial/arkveld-ex.ts | Updated trigger ID and added Chinese localization for extreme version |
| ui/raidboss/data/07-dt/deepdungeon/*.ts | Added Chinese translations for various deep dungeon encounters (floors 71-100 and final verse) |
| plugin/*/Properties/AssemblyInfo.cs | Version updated from 99.170.0 to 99.171.0 |
| package.json | Version updated to 99.171.0 |
| build/build.ps1 | Visual Studio path changed (potential issue detected) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if ($in -eq '1') | ||
| { | ||
| $vspath = "C:\Program Files\Microsoft Visual Studio\2022\Community" | ||
| $vspath = "C:\Program Files\Microsoft Visual Studio\18\Community" |
There was a problem hiding this comment.
The Visual Studio version path has been changed from "2022" to "18". This appears to be incorrect as Visual Studio 2026 (if it exists) would use version "2026", not "18". Visual Studio version numbers follow the pattern:
- VS 2019 = version 16
- VS 2022 = version 17
- VS 2025 (hypothetical) = version 18
If this is intended to reference VS 2026, it should be "2026" not "18". Please verify the correct Visual Studio installation path.
| $vspath = "C:\Program Files\Microsoft Visual Studio\18\Community" | |
| $vspath = "C:\Program Files\Microsoft Visual Studio\2022\Community" |
There was a problem hiding this comment.
see this url: https://learn.microsoft.com/en-us/visualstudio/releases/2026/release-notes
version of vs2026 is 18
| cn: '${mech1} => ${mech2}', | ||
| ko: '${mech1} 🔜 ${mech2}', |
There was a problem hiding this comment.
Incomplete Korean localization: The Korean translation is missing for this line while Chinese was added. For consistency with the rest of the file, Korean localization should be included.
There was a problem hiding this comment.
ko resources always use '🔜' instead of '=>'. not same other locales
Introduce initial triggers and timeline for the Guardian Arkveld fight in The Windward Wilds, along with localization for ability names in Chinese. Update the version to 99.171.0 and adjust the Visual Studio path for 2026.