github 관련 정리중 #217
Merged
github 관련 정리중 #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR appears to be focused on GitHub-related cleanup and reorganization, involving version updates and workflow modifications. The main purpose is to update version numbers and streamline GitHub workflow configurations.
- Updated version numbers across multiple assembly files and package.json from 99.158.0 to 99.159.0
- Removed several GitHub workflow files for linting operations
- Simplified remaining workflow names and removed documentation
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ui/raidboss/data/04-sb/ultimate/ultima_weapon_ultimate.ts | Refactored array initialization to use individual variables before constructing the array |
| plugin/CactbotOverlay/Properties/AssemblyInfo.cs | Updated assembly version from 99.158.0.0 to 99.159.0.0 |
| plugin/CactbotEventSource/Properties/AssemblyInfo.cs | Updated assembly version from 99.158.0.0 to 99.159.0.0 |
| package.json | Updated package version from 99.158.0 to 99.159.0 |
| .github/workflows/lint-version.yml | Completely removed version linting workflow |
| .github/workflows/lint-test.yml | Completely removed test linting workflow |
| .github/workflows/lint-script.yml | Completely removed script linting workflow |
| .github/workflows/lint-doc.yml | Completely removed documentation linting workflow |
| .github/workflows/build.yml | Simplified workflow name from "빌드-릴리즈" to "빌드" |
| .github/workflows/branches.yml | Simplified workflow name from "업데이트-브랜치" to "브랜치" |
| .github/workflows/README.md | Completely removed workflow documentation |
| numDir[1]++; | ||
| n1++; | ||
| } | ||
| const numDir = [n0, n1, n2, n3]; // north, east, south, west |
There was a problem hiding this comment.
[nitpick] The refactoring introduces unnecessary complexity by replacing a direct array initialization with individual variables. The original const numDir = [0, 0, 0, 0] approach was cleaner and more maintainable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.