Converting a string from upper case to lower case#201
Open
Unnam29 wants to merge 2 commits intokscanne:masterfrom
Open
Converting a string from upper case to lower case#201Unnam29 wants to merge 2 commits intokscanne:masterfrom
Unnam29 wants to merge 2 commits intokscanne:masterfrom
Conversation
kscanne
reviewed
Feb 16, 2023
Owner
kscanne
left a comment
kscanne
left a comment
There was a problem hiding this comment.
This code makes no attempt to deal with the complexities outlined in the problem statement. The code needs to handle various language-specific cases, and in particular should pass the test cases given in the .tsv file. This code clearly does not.
kscanne
reviewed
Mar 9, 2023
| @@ -0,0 +1,23 @@ | |||
| function getTriangleType(jsonString) { | |||
Owner
There was a problem hiding this comment.
As we discussed, I said I would review this submission even though it was late. But you need to read the assignment again — this was not the task for the lab. In fact, I made it clear you were not intended to implement the function... only write test cases in the specified format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.