Open
Conversation
fulvius31
reviewed
Feb 16, 2023
fulvius31
reviewed
Feb 16, 2023
fulvius31
suggested changes
Feb 16, 2023
fulvius31
left a comment
fulvius31
left a comment
There was a problem hiding this comment.
@PMIRUKULA It should be nice if you can provide me a way to test the code.
Did you try all the test cases ?
Author
yes, I have tested all the cases. |
|
Maybe it would be better to use JUnit tests so I can easily watch on them and test it. |
kscanne
reviewed
Feb 23, 2023
S23/pmirukula/Conversion.java
Outdated
| { | ||
| if(str.contains("I")) | ||
| { | ||
| str = str.replaceAll("I", " \0u131"); |
Owner
There was a problem hiding this comment.
Did you test this? Looks like a bug. And also a magic number.
S23/pmirukula/Conversion.java
Outdated
| output = str.toLowerCase(new Locale(str_lang)); | ||
| } | ||
| } | ||
| else if(str_lang.equals("ga-IE")|| str_lang.equals("ga") ) |
Owner
There was a problem hiding this comment.
BCP-47 codes can be very complicated. This is far from general enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On running my code, a text file would be generated in same location with output in it.