Include the description field in TriggerSummaryData#14
Open
zaphod42 wants to merge 1 commit intokryptek:masterfrom
Open
Include the description field in TriggerSummaryData#14zaphod42 wants to merge 1 commit intokryptek:masterfrom
zaphod42 wants to merge 1 commit intokryptek:masterfrom
Conversation
The trigger summary data can have a lot of different formats to it. When the event API is used to trigger an incident it has a "description" field but not a "subject" field. When nagios triggers an incident it has a "subject" field but not a "description" field. In order to keep with the model of this library, this adds another field rather than trying to combine the fields together. A user can decide which of the fields to use rather then the library trying to decide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trigger summary data can have a lot of different formats to it. When
the event API is used to trigger an incident it has a "description"
field but not a "subject" field. When nagios triggers an incident it has
a "subject" field but not a "description" field.
In order to keep with the model of this library, this adds another field
rather than trying to combine the fields together. A user can decide
which of the fields to use rather then the library trying to decide.