Skip to content

use the variables for AWS access credentials rather than the ENV variabl...#8

Open
techlunacy wants to merge 1 commit intokryptek:masterfrom
techlunacy:master
Open

use the variables for AWS access credentials rather than the ENV variabl...#8
techlunacy wants to merge 1 commit intokryptek:masterfrom
techlunacy:master

Conversation

@techlunacy
Copy link
Copy Markdown

allows the user to set the aws credentials in the deploy.rb file as such:
set :aws_access_key_id, "XXXXXXXXXXXXXXXXXXXXXXX"
set :aws_secret_access_key, "XXXXXXXXXXXXxXXXXXXXXXXXXX"

@antonbabenko
Copy link
Copy Markdown

I think it would be best if it checks for local variables and fallback to ENV.

@kryptek
Copy link
Copy Markdown
Owner

kryptek commented Oct 16, 2014

I'm in favor of such a change. Would @techlunacy care to ammend the code?

aws_secret_access_key: fetch(:aws_secret_access_key) || ENV['AWS_SECRET_ACCESS_KEY']
aws_access_key_id: fetch(:aws_access_key_id) || ENV['AWS_ACCESS_KEY_ID']

If not I can just edit the code and push that up. I'll give'em until Monday, Oct 20.

@techlunacy
Copy link
Copy Markdown
Author

i would have thought these lines (on 15/16) would have handled what you are asking for in this situation

_cset(:aws_secret_access_key, ENV['AWS_SECRET_ACCESS_KEY'])         

_cset(:aws_access_key_id, ENV['AWS_ACCESS_KEY_ID'])

if not i will add what you are asking

@kryptek
Copy link
Copy Markdown
Owner

kryptek commented Oct 17, 2014

Ahh.. yeah, sorry about that. @techlunacy.

In this case, @antonbabenko , you would explicitly set your keys in deploy.rb to something else if you didn't want ENV defaults..

@antonbabenko
Copy link
Copy Markdown

ok, point taken :) Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants