use the variables for AWS access credentials rather than the ENV variabl...#8
Open
techlunacy wants to merge 1 commit intokryptek:masterfrom
Open
use the variables for AWS access credentials rather than the ENV variabl...#8techlunacy wants to merge 1 commit intokryptek:masterfrom
techlunacy wants to merge 1 commit intokryptek:masterfrom
Conversation
|
I think it would be best if it checks for local variables and fallback to ENV. |
Owner
|
I'm in favor of such a change. Would @techlunacy care to ammend the code? aws_secret_access_key: fetch(:aws_secret_access_key) || ENV['AWS_SECRET_ACCESS_KEY']
aws_access_key_id: fetch(:aws_access_key_id) || ENV['AWS_ACCESS_KEY_ID']If not I can just edit the code and push that up. I'll give'em until Monday, Oct 20. |
Author
|
i would have thought these lines (on 15/16) would have handled what you are asking for in this situation if not i will add what you are asking |
Owner
|
Ahh.. yeah, sorry about that. @techlunacy. In this case, @antonbabenko , you would explicitly set your keys in deploy.rb to something else if you didn't want ENV defaults.. |
|
ok, point taken :) Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allows the user to set the aws credentials in the deploy.rb file as such:
set :aws_access_key_id, "XXXXXXXXXXXXXXXXXXXXXXX"
set :aws_secret_access_key, "XXXXXXXXXXXXxXXXXXXXXXXXXX"