Optimize DELETE RETURNING by passing columns through from scan #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of fetching columns by rowid in PhysicalDelete for RETURNING clause, add required columns to the initial table scan and pass them through directly. This eliminates expensive point lookups and improves performance significantly. Benchmark results (1M rows): - 3 columns: 2.2x faster - 10 columns: 6.4x faster For tables with generated columns, falls back to the original fetch-by-rowid path since generated columns cannot be scanned directly. Changes: - Add return_columns vector to LogicalDelete to track column mappings - Modify bind_delete.cpp to add RETURNING columns to scan - Update PhysicalDelete to reference columns from input chunk - Add benchmarks for DELETE RETURNING performance
krleonid
force-pushed
the
optimize-delete-returning
branch
from
ef28123 to
bdc3976
Compare
Tests added to test/sql/returning/returning_delete.test: - DELETE RETURNING without generated columns (optimized scan pass-through path) - DELETE RETURNING with column in both WHERE and RETURNING - DELETE RETURNING with VIRTUAL generated columns (fallback fetch-by-rowid path) - DELETE RETURNING with generated column in middle of table - DELETE RETURNING with multiple generated columns - DELETE RETURNING with generated VARCHAR column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of fetching columns by rowid in PhysicalDelete for RETURNING clause, add required columns to the initial table scan and pass them through directly. This eliminates expensive point lookups and improves performance significantly.
Benchmark results (1M rows):
For tables with generated columns, falls back to the original fetch-by-rowid path since generated columns cannot be scanned directly.
Changes: