Optimize DELETE by scanning indexed columns at bind time #11
+367
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR eliminates the fallback path in PhysicalDelete that fetched columns by row ID when unique indexes exist but no RETURNING clause is present. Changes: - Add BindDeleteIndexColumns helper to scan indexed columns at bind time - Add MERGE INTO overload that builds projection expressions - Extract common ConvertScanToProjectionMapping helper to reduce duplication - Remove fallback fetch-by-row-ID path in physical_delete.cpp - Add tests for DELETE and MERGE INTO DELETE with indexed tables The optimization passes indexed columns through from the scan, avoiding the need to fetch them separately during DELETE execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates the fallback path in PhysicalDelete that fetched columns by row ID when unique indexes exist but no RETURNING clause is present.
Changes:
The optimization passes indexed columns through from the scan, avoiding the need to fetch them separately during DELETE execution.