Optimize MERGE INTO DELETE RETURNING by passing columns through from scan #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scan Instead of fetching columns by row ID in the fallback path, pass physical columns through from the scan for MERGE INTO DELETE operations with RETURNING. This optimization mirrors the approach used in regular DELETE RETURNING (PR duckdb#20485) but extends it to MERGE INTO statements. Changes: - Add delete_return_columns vector to LogicalMergeInto to map physical columns to their positions in the projection - Populate delete_return_columns in bind_merge_into.cpp when RETURNING is used with a DELETE action - Add serialization for the new field - Add tests for MERGE INTO DELETE RETURNING with generated columns
- Move BindDeleteReturningColumns helper methods from bind_update.cpp to binder.cpp - Place them next to BindReturning for logical grouping of RETURNING-related helpers - Add overloaded version that handles projection mapping for MERGE INTO - Simplify bind_delete.cpp and bind_merge_into.cpp by using the shared helpers
- Add test for DELETE RETURNING with rowid (not supported) - Add test for MERGE INTO DELETE RETURNING with rowid (not supported)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes MERGE INTO DELETE RETURNING by passing physical columns through from the scan instead of fetching them by row ID in the fallback path.
Changes
delete_return_columnsvector toLogicalMergeIntoto map physical columns to their positions in the projectiondelete_return_columnsinbind_merge_into.cppwhen RETURNING is used with a DELETE actionContext
This optimization mirrors the approach used in regular DELETE RETURNING (PR duckdb#20485) but extends it to MERGE INTO statements. Previously, MERGE INTO DELETE RETURNING would fall back to fetching columns by row ID, which is slower than passing them through from the scan.
Testing