Catch async errors in nested generators#55
Open
SofianeDjellouli wants to merge 8 commits intokrasimir:masterfrom
Open
Catch async errors in nested generators#55SofianeDjellouli wants to merge 8 commits intokrasimir:masterfrom
SofianeDjellouli wants to merge 8 commits intokrasimir:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
The use of the
yield*keyword allows us to delegate operations to nested generators. By creating a new generator usingyield*and atry/catchblock, we can catch async errors in nested generators.I removed the
try/catchblock around the inside call ofhandleGeneratorbecause:errors happening in nested generators are now caught in the new
nestedGeneratorother errors happening in
handleGeneratorare caught in the function itselfit makes the code redundant to have a
try/catchblock two times.I also added tests for various scenarios.
Solves #56