Conversation
Contributor
Author
|
I know there is PR updating the github action to execute the tests, but it was failing the build here, and I've just update it here too. |
kpacha
previously approved these changes
Sep 3, 2025
thedae
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When partials reads had been made (because of slow response, or chunked response), the response was being cached as if it was already completed.
The underlying network connection reader does not support returning an EOF, so, unless we know the size of response (when the server provides a
Content-Length) we are not able to detect the end of the body (is the calling function that is for example parsing a streaming json, that knows when it has finished reading it .. so when it closes the body, we know that the "body content" was readed).