Add config option to reuse descriptor_set #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjodinchr
force-pushed
the
pr/reuse-descriptor-set
branch
3 times, most recently
from
033342b to
344ef23
Compare
Contributor
Author
|
@kpet could you please refresh the swiftshader artifact? |
rjodinchr
force-pushed
the
pr/reuse-descriptor-set
branch
2 times, most recently
from
deb5298 to
85db145
Compare
Contributor
Author
|
@kpet I'm having trouble reproducing, and just looking at the code I don't see anything wrong. Can you have a quick look, to see if you spot something. |
rjodinchr
force-pushed
the
pr/reuse-descriptor-set
branch
6 times, most recently
from
e5ede7c to
36a408a
Compare
rjodinchr
force-pushed
the
pr/reuse-descriptor-set
branch
from
36a408a to
aa6ea64
Compare
Contributor
Author
|
🎉 CI is green! |
On Mali devices, using the ARM DDK, some application quickly get to a point where the driver consider the memory as fragemented and it not capable of allocated new descriptor_set anymore. To avoid that, do not free descriptor_set, reuse ones that have been release from the application point of view.
rjodinchr
force-pushed
the
pr/reuse-descriptor-set
branch
from
aa6ea64 to
5c83b8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mali devices, using the ARM DDK, some application quickly get to a point where the driver consider the memory as fragemented and it not capable of allocated new descriptor_set anymore.
To avoid that, do not free descriptor_set, and when it is not possible to allocate new ones, reuse ones that have been release from the application point of view.