Skip to content

Reply#1

Draft
kousu wants to merge 8 commits intomatterbridgefrom
reply
Draft

Reply#1
kousu wants to merge 8 commits intomatterbridgefrom
reply

Conversation

@kousu
Copy link
Copy Markdown
Owner

@kousu kousu commented Feb 10, 2026

Implement XEP 0461

kousu and others added 3 commits February 10, 2026 11:38
@kousu @claude
Add XEP-0461 Message Replies support
b5fdf41 
Add ReplyTo field to Chat struct and include <reply> element in Send()
when set. This enables XMPP clients to send messages that reference
a parent message per the XEP-0461 specification.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@sh4sh
added ReplyID to Chat struct to go with the ReplyTo, and added client…
30963c2 
…Reply struct to build clientMessage's reply object since ID and To are nested.
@sh4sh
assigned ReplyID and ReplyTo in Chat, built replytext and added to st…
8517b20 
…anza
@sh4sh
Copy link
Copy Markdown
Collaborator

sh4sh commented Feb 10, 2026

Okay, this is working now.

We might want to rebase onto matterbridge/go-xmpp/master since we based off the matterbridge branch which i dont think is in prod

@sh4sh
Copy link
Copy Markdown
Collaborator

sh4sh commented Feb 10, 2026

It's not rendering correctly becuase it is slightly out of compliance with xep. We need to build stanza-id into here so we can grab the stanza-id id for use, right now it is using (defaulting?) to the top-level message id

@kousu
Copy link
Copy Markdown
Owner Author

kousu commented Feb 10, 2026 •
edited
Loading

We might want to rebase onto matterbridge/go-xmpp/master since we based off the matterbridge branch which i dont think is in prod

Oh yeah what happened here. 34 commits? That's wrong. I'll try to fix that.

It's not rendering correctly becuase it is slightly out of compliance with xep. We need to build stanza-id into here so we can grab the stanza-id id for use, right now it is using (defaulting?) to the top-level message id

  • Working in Conversations/Cheogram

    image

  • Not working in Dino

    image

  • Not working in Gajim

    image

XEP says

For messages of type 'groupchat', the stanza's 'id' attribute MUST NOT be used for replies. Instead, in group chat situations, the ID assigned to the stanza by the group chat itself must be used. This is discovered in a element with a 'by' attribute that matches the bare JID of the group chat, as defined in Unique and Stable Stanza IDs (XEP-0359) [4].

"the stanza's 'id' attribute" means the outer <message id='....'>. The terminology is a bitch here because <stanza-id> is a sub-element attached to the outer <message> element, but it's that outer <message> that's "the stanza".

@kousu kousu changed the base branch from master to matterbridge February 10, 2026 21:37
@kousu
Copy link
Copy Markdown
Owner Author

kousu commented Feb 10, 2026 •
edited
Loading

Okay I fixed the mergebase

@sh4sh
Copy link
Copy Markdown
Collaborator

sh4sh commented Feb 11, 2026 •
edited
Loading

ok do u like? :-)

@sh4sh sh4sh mentioned this pull request Feb 11, 2026
Closed
@sh4sh
Copy link
Copy Markdown
Collaborator

sh4sh commented Feb 11, 2026 •
edited
Loading

this PR is tied to kousu/matterbridge#1

@sh4sh sh4sh mentioned this pull request Feb 12, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kousu @sh4sh