Conversation
- Removed the `drop_buffer_barriers` function as it was redundant. - Updated buffer barrier access patterns to use `D3D12_BARRIER_ACCESS_COMMON` instead of `D3D12_BARRIER_ACCESS_UNORDERED_ACCESS`. - Simplified the UAV clear function to always create a R32_UINT UAV, ensuring compatibility regardless of buffer stride. - Added explicit layout transition for storage textures during creation to prevent silent failures on some drivers. - Enhanced compute submission barriers to ensure proper visibility of UAV writes to subsequent reads.
- Added debug assertions to ensure buffer size and view size are evenly divisible by element stride, preventing potential stride mismatches. - Introduced a warning for write operations when data length is not a multiple of the element stride for storage buffers, improving error handling and debugging.
- Updated debug assertions in buffer creation and view functions to use `is_multiple_of` for clarity and consistency. - Simplified command list casting in texture creation for better readability. - Cleaned up formatting in UAV clear function to enhance code maintainability.
- Added support for MTLHazardTrackingMode::Tracked in both buffer and texture heap descriptors to enhance memory management and resource safety. - Updated the create functions in HeapAllocator and TextureHeapAllocator to set the hazard tracking mode during heap creation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.