Skip to content

WIP Fix #123 and potenitally others: Rename methods returning lists to use plural names #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sdruskat wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

WIP Fix #123 and potenitally others: Rename methods returning lists to use plural names #125

sdruskat wants to merge 1 commit into from

Conversation

@sdruskat
Copy link
Contributor

@sdruskat sdruskat commented Jul 11, 2017

Deprecates the old method and adds a new one with the same functionality and added 's' in the method name.

@sdruskat
Fix #123
bfe7f45 
- Deprecate confusingly named method SGraph#getLayerByName
- Add method SGraph#getLayersByName
- Adapt implementation
@sdruskat sdruskat changed the title Fix #123: Rename method getLayerByName [WIP] Fix #123 and potenitally others: Rename methods returning lists to use plural names May 16, 2018
@sdruskat sdruskat changed the title [WIP] Fix #123 and potenitally others: Rename methods returning lists to use plural names WIP Fix #123 and potenitally others: Rename methods returning lists to use plural names May 16, 2018
@sdruskat
Copy link
Contributor Author

sdruskat commented May 16, 2018

Check globally for methods returning lists to use plural names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sdruskat