Provide name, public and system id in Doctype event#57
Merged
kornelski merged 1 commit intokornelski:mainfrom Nov 15, 2025
Merged
Provide name, public and system id in Doctype event#57kornelski merged 1 commit intokornelski:mainfrom
kornelski merged 1 commit intokornelski:mainfrom
Conversation
Improve Doctype parsing to distinguish internal subset state and process public and system id, processing them into fields passed to the Doctype event. Introducing extra states for system and public parts of ExternalId. Moving parts of what used to be process in Doctype substate "Outside" to substate "InternalSubset" where it fits better. Passes three additional tests from xmltest.xml that deal with Doctype validity. Fixes kornelski#55.
Author
|
Friendly ping @kornelski , would you be ready to consider an API change as proposed here? And combine this with #56? |
Owner
|
Thanks for the PR. The code looks good. Unfortunately, I've made a mistake of exposing the DOCTYPE as a |
Author
|
IMO one acceptable option is to leave the |
Owner
|
I've exposed it via The project is in the middle of switching from xml-rs crate to the xml crate, so I don't want to cause any more churn on top of that until most users migrate over. |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 20, 2025
Improved DOCTYPE parsing, string conversion for XMLVersion and allowing documents with version 1.x. Covers Googler pull requests 54, 56, 57: kornelski/xml-rs#54 kornelski/xml-rs#56 kornelski/xml-rs#57 Changes merged in upstream but no version released yet. Covers $ git log 1.1.0.. bd8fe07 Allow parsing of XML Version 1.x to improve conformance 18c4d62 Move assert_match macro 30227e8 Nicer comparison for OwnedName f0e34b3 Thinner string type aba9a85 Backwards-compatible DOCTYPE properties 7da7012 Provide name, public and system id in Doctype event 34458a2 Add `as_str()` method to `XmlVersion` `enum`. Bug: 441911594 Change-Id: Icc58864e4393fe2725f9137f52cf92c23a5f3ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7172953 Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1547919}
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 21, 2025
Use Doctype Parsing functionality from upstream [1] to replace local workaround based on regular expressions. [1] kornelski/xml-rs#57 Bug: 441911594 Change-Id: If49a5629bb57e17e6bfd3985e01b198e8c437bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7172025 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/main@{#1548359}
mohd-akram
pushed a commit
to gsource-mirror/chromium-src-third_party-rust
that referenced
this pull request
Jan 9, 2026
Improved DOCTYPE parsing, string conversion for XMLVersion and allowing documents with version 1.x. Covers Googler pull requests 54, 56, 57: kornelski/xml-rs#54 kornelski/xml-rs#56 kornelski/xml-rs#57 Changes merged in upstream but no version released yet. Covers $ git log 1.1.0.. bd8fe07 Allow parsing of XML Version 1.x to improve conformance 18c4d62 Move assert_match macro 30227e8 Nicer comparison for OwnedName f0e34b3 Thinner string type aba9a85 Backwards-compatible DOCTYPE properties 7da7012 Provide name, public and system id in Doctype event 34458a2 Add `as_str()` method to `XmlVersion` `enum`. Bug: 441911594 Change-Id: Icc58864e4393fe2725f9137f52cf92c23a5f3ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7172953 Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1547919} NOKEYCHECK=True GitOrigin-RevId: e35fe768bc00fbe9e2c49e6f5334140eb8446b50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Doctype parsing to distinguish internal subset state and process public and system id, processing them into fields passed to the Doctype event.
Introducing extra states for system and public parts of ExternalId.
Moving parts of what used to be process in Doctype substate "Outside" to substate "InternalSubset" where it fits better.
Passes three additional tests from xmltest.xml that deal with Doctype validity.
Fixes #55.