-
Notifications
You must be signed in to change notification settings - Fork 29
Upgrade to Ubuntu 22.04 to keep workflows running #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It's not quite that simple. That means it wouldn't work on older versions. But it is time to switch to 22.04. |
|
Downgraded to 22.04 following your concern. 24.04 should come after 22.04 is gone from actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the GitHub Actions runner from Ubuntu 20.04 to Ubuntu 22.04 to resolve workflow failures.
- Updated the "runs-on" value in the CI configuration file (.github/workflows/toolchain.yml).
Frenzie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This'll necessitate we upgrade all of our Docker images, too. I'm not going to do that tonight, though. :-)
|
Or we could build the toolchains in docker using our base image? |
|
We could, but is it worth the trouble? I figure we want to move those away from 20.04 as well now that it's EOL. |
|
It's still receiving security updates. The real question, is do we build our AppImage on a newer LTS (losing support for older systems). |
|
You mean paid security updates? Unless you're nitpicking about the fact that it's still a whole month away. Anyway, if it works along these general lines it's certainly fine by me. container:
image: koreader/kobase:etc |
|
@benoit-pierre Only until May 2025 so it's in deathbed already. For our purpose it could be treated dead already. |
|
This can be closed (superseded by #52). |

Ubuntu 20.04 is now gone so it's been failing. Upgrading to 22.04 will fix this.
This change is