Skip to content

Conversation

@NoaHimesaka1873
Copy link
Contributor

@NoaHimesaka1873 NoaHimesaka1873 commented Apr 19, 2025

Ubuntu 20.04 is now gone so it's been failing. Upgrading to 22.04 will fix this.


This change is Reviewable

@Frenzie
Copy link
Member

Frenzie commented Apr 19, 2025

It's not quite that simple. That means it wouldn't work on older versions. But it is time to switch to 22.04.

@NoaHimesaka1873
Copy link
Contributor Author

NoaHimesaka1873 commented Apr 19, 2025

Downgraded to 22.04 following your concern. 24.04 should come after 22.04 is gone from actions.

@NoaHimesaka1873 NoaHimesaka1873 changed the title Upgrade to Ubuntu 24.04 to keep workflows running Upgrade to Ubuntu 22.04 to keep workflows running Apr 19, 2025
@Frenzie
Copy link
Member

Frenzie commented Apr 19, 2025

I just spotted a curious new thing I'm going to try to see what happens.
image

@Frenzie Frenzie requested a review from Copilot April 19, 2025 17:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the GitHub Actions runner from Ubuntu 20.04 to Ubuntu 22.04 to resolve workflow failures.

  • Updated the "runs-on" value in the CI configuration file (.github/workflows/toolchain.yml).

Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll necessitate we upgrade all of our Docker images, too. I'm not going to do that tonight, though. :-)

@benoit-pierre
Copy link
Member

Or we could build the toolchains in docker using our base image?

@Frenzie
Copy link
Member

Frenzie commented Apr 21, 2025

We could, but is it worth the trouble? I figure we want to move those away from 20.04 as well now that it's EOL.

@benoit-pierre
Copy link
Member

It's still receiving security updates. The real question, is do we build our AppImage on a newer LTS (losing support for older systems).

@Frenzie
Copy link
Member

Frenzie commented Apr 21, 2025

You mean paid security updates? Unless you're nitpicking about the fact that it's still a whole month away. Anyway, if it works along these general lines it's certainly fine by me.

    container:
      image: koreader/kobase:etc

@NoaHimesaka1873
Copy link
Contributor Author

@benoit-pierre Only until May 2025 so it's in deathbed already. For our purpose it could be treated dead already.

@benoit-pierre
Copy link
Member

This can be closed (superseded by #52).

@Frenzie Frenzie closed this May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants