Fix exception being thrown on changelevel#14
Open
AnAkkk wants to merge 1 commit intokoraktor:masterfrom
Open
Conversation
Owner
|
Finally back at this problem… Doesn’t this make the |
Author
|
I don't think it would, the RCONTerminator will still be sent after a successful reply. It just won't throw the exception if there haven't been any reply. |
Author
|
FYI it's now even worse on Dota 2 Reborn (Source 2), Valve changed a bit the rcon code apparently, the workaround no longer works and steam condenser just throw a timeout exception every time as the server won't reply to the 2nd packet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the problem described in koraktor/steam-condenser#270