Update deps #207

IvanKiral · 2025-12-22T11:32:02Z

Motivation

Which issue does this fix? Fixes #issue number

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

Code follows coding conventions held in this repo
Automated tests have been added
Tests are passing
Docs have been updated (if applicable)
Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

JiriLojda · 2025-12-23T17:06:54Z

src/lib/IFrameCommunicator.ts

  public initialize(): void {
-    if (!window) {
-      throw InvalidEnvironmentError('IFrameCommunicator can only be initialized in a browser environment.');
+    if (typeof window === "undefined") {


window === undefined is not enough?

Here I have an error then This comparison appears to be unintentional because the types 'Window & typeof globalThis' and 'string' have no overlap.ts(2367)

I kind of decided to rather use this workaround cuz I believe this check makes sense. On the other hand, we probably might check whether we are in a browser somewhere in the top class and not check it in every class, though I did not want to really totally refactor this solution in this PR to not break it :D

sure, this is just a nitpick and I am totally ok with the current approach. Just thought that typeof window === "undefined" should work the same as window === undefined. In you error message you probably forgot to remove the " around undefined, because it tries to match against string instead of undefined. But maybe TS doesn't include undefined in the type of window so that might throw an error as well. Leave it as it is then.

src/lib/IFrameCommunicator.ts

src/models/index.ts

src/utils/dataAttributes/parser.ts

src/utils/liveReload.ts

src/web-components/abstract/KSLCustomElement.ts

src/web-components/tokens/colors.ts

src/sdk.ts

JiriLojda · 2025-12-23T17:43:23Z

biome.json

+      "linter": {
+        "rules": {
+          "performance": {
+            "noBarrelFile": "off"


When there is this override here, we don't need the comment in the file, right?

When I remove the override and run biome, it shows only one error (and one warning for unexpected any). I'd prefer removing the override and removing that one reexport (ideally) or at least putting an ignore comment to that one place.

JiriLojda · 2025-12-23T17:47:10Z

tsconfig.json

-
+{
+  "files": [],
+  "references": [


Do we need this "root" tsconfig?

This is so the ts lsp could work for both test config and build configs. The solution was consulted with AI. Tests uses react.jsx for testing components. If i remember correctly, I was fighting cursor (ts lsp) with false React errors in tests.

I tried to rename tsconfig.build.json to tsconfig.json and update all the references to it (deleting the original tsconfig.json) and everything seems to work for me. That would be a lot more reasonable setup in my opinion. Can you try that?

JiriLojda

Once we update the eslint config and biome config, lets update it here as well and remove the unnecessary eslint ignores.

JiriLojda · 2026-01-06T13:46:41Z

src/utils/customElements.ts

+): boolean {
  const highlightType = getHighlightTypeForElement(element);

+  // eslint-disable-next-line @typescript-eslint/switch-exhaustiveness-check


Since the highlightType is an enum (finite number of elements), I'd also prefer here to remove the default and instead enumerate the rest of the options as cases for the rest. Then you'll be able to remove the ignore comment and whenever someone adds a new element to the enum, they'll be forced to add a case for it here. This will help avoid a scenario when one forgets to add a case here and cause a bug, because for their new enum element a non-default behavior would be required here.

JiriLojda · 2026-01-06T13:52:25Z

biome.json

+      "linter": {
+        "rules": {
+          "performance": {
+            "noBarrelFile": "off"


When I remove the override and run biome, it shows only one error (and one warning for unexpected any). I'd prefer removing the override and removing that one reexport (ideally) or at least putting an ignore comment to that one place.

JiriLojda · 2026-01-06T13:59:53Z

tsconfig.json

-
+{
+  "files": [],
+  "references": [


I tried to rename tsconfig.build.json to tsconfig.json and update all the references to it (deleting the original tsconfig.json) and everything seems to work for me. That would be a lot more reasonable setup in my opinion. Can you try that?

JiriLojda · 2026-01-06T14:01:43Z

biome.json

@@ -0,0 +1,26 @@
+{
+  "$schema": "https://biomejs.dev/schemas/2.0.x/schema.json",
+  "extends": ["@kontent-ai/biome-config/base"],


Can we have the react rules as well? (Can be just for testing, but probably won't hurt for other files.)

JiriLojda · 2026-01-06T14:02:02Z

biome.json

+  "$schema": "https://biomejs.dev/schemas/2.0.x/schema.json",
+  "extends": ["@kontent-ai/biome-config/base"],
+  "files": {
+    "includes": ["src/**/*.ts", "src/**/*.tsx"]


The biome should format and lint the test files as well.

IvanKiral added 3 commits December 22, 2025 10:12

update eslint config

8784894

update tsconfigs and package.json

7df91f9

fix lint errors

d71896a

IvanKiral force-pushed the update_deps branch from 7e3660c to d71896a Compare December 22, 2025 11:45

IvanKiral added 7 commits December 22, 2025 15:37

update kontent ai eslint config

19e3543

update biome lints errors

186399d

disable promise-function-async in eslint

9c06337

run biome fix

33ca5f8

update workflow

f0cd58d

return back this in kslCustomElement

852e182

change errors to proper classes

c53fa31

IvanKiral marked this pull request as ready for review December 23, 2025 10:19

IvanKiral requested a review from a team as a code owner December 23, 2025 10:19

JiriLojda requested changes Dec 23, 2025

View reviewed changes

IvanKiral added 2 commits January 5, 2026 07:56

address review comments

20e080c

fix remaining biome warnings

efd69fb

IvanKiral requested a review from JiriLojda January 5, 2026 11:59

JiriLojda requested changes Jan 6, 2026

View reviewed changes

Update deps #207

Are you sure you want to change the base?

Update deps #207

Uh oh!

Conversation

IvanKiral commented Dec 22, 2025

Motivation

Checklist

How to test

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JiriLojda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants