Don't check file existence for entities not part of sync run #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiriLojda
force-pushed
the
fix_entity_callbacks_params
branch
from
60e472b to
873a67d
Compare
JiriLojda
force-pushed
the
fix_entity_callbacks_params
branch
from
6ebce8d to
4b39435
Compare
JiriLojda
force-pushed
the
fix_entity_callbacks_params
branch
from
4b39435 to
3fdb949
Compare
IvanKiral
requested changes
Jan 2, 2026
.github/workflows/build.yml
Outdated
| build: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 |
Contributor
There was a problem hiding this comment.
please updat to v6 for checkoutg and check version of others actions
.github/workflows/release.yml
Outdated
| - run: pnpm publish --access=public --no-git-checks | ||
| if: ${{!github.event.release.prerelease}} | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.NPM_API_KEY }} |
Contributor
There was a problem hiding this comment.
please remove node_auth_token ( I tihnk its only for release) and change it to oidc
src/modules/sync/validation.ts
Outdated
| export const validateSyncModelFolder = async (folderPath: string) => { | ||
| export const validateSyncModelFolder = async ( | ||
| folderPath: string, | ||
| entities: ReadonlySet<SyncEntityName>, |
Member
Author
There was a problem hiding this comment.
Conceptually, I have to agree with Claude that it makes sense for this to be a readonly set. Having said that, I do agree with you that it is unnecessary complication as we never have the data in this structure so I refactored the function to accept an array of entity names instead.
IvanKiral
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Which issue does this fix? Fixes #
issue numberIf no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?