Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #750 +/- ##
==========================================
+ Coverage 49.02% 49.32% +0.29%
==========================================
Files 20 21 +1
Lines 2707 2723 +16
==========================================
+ Hits 1327 1343 +16
Misses 1250 1250
Partials 130 130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This change introduces an optional `LabelSelector` field in MPC's configuration. The LabelSelector is used to calculate whether MPC should reconcile a TaskRun or not. As an example, it can be used to validate that the PipelineRun behind the TaskRun was effectively added to a kueue's Queue by checking the presence of the kueue's `kueue.x-k8s.io/queue-name` label. A check at boot time is added to make sure a new rollout fails if the configuration is not valid. In case of malformed TaskRuns, the user experience will be of a Pending Pod waiting for the Secret to be created until the owner TaskRun times-out. This is the default behavior in MPC. Signed-off-by: Francesco Ilario <filario@redhat.com> assisted-by: Cursor rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
filariow
force-pushed
the
taskrun-labelselector
branch
from
59163ca to
2a8b223
Compare
|
This will ensure that the plr was proceed by kueue, but not that the right VM was requested. |
| ) | ||
|
|
||
| const ( | ||
| HostConfig string = "host-config" |
There was a problem hiding this comment.
Maybe move to pkg/constant and use here and in 'taskrun.go'?
| return nil, err | ||
| } | ||
|
|
||
| // ensure configuration is valid before starting |
There was a problem hiding this comment.
Does it makes sense to move it higher, and use in TR cache? (see line 90?)
4 participants
This change introduces an optional
LabelSelectorfield in MPC's configuration. The LabelSelector is used to calculate whether MPC should reconcile a TaskRun or not.As an example, it can be used to validate that the PipelineRun behind the TaskRun was effectively added to a kueue's Queue by checking the presence of the kueue's
kueue.x-k8s.io/queue-namelabel.A check at boot time is added to make sure a new rollout fails if the configuration is not valid.
In case of malformed TaskRuns, the user experience will be of a Pending Pod waiting for the Secret to be created until the owner TaskRun times-out. This is the default behavior in MPC.
Signed-off-by: Francesco Ilario filario@redhat.com
assisted-by: Cursor
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED