Temporary fix to narrow the scope of cached TaskRuns to prevent OOMs#336
Draft
mshaposhnik wants to merge 3 commits intokonflux-ci:mainfrom
Draft
Temporary fix to narrow the scope of cached TaskRuns to prevent OOMs#336mshaposhnik wants to merge 3 commits intokonflux-ci:mainfrom
mshaposhnik wants to merge 3 commits intokonflux-ci:mainfrom
Conversation
Signed-off-by: Max Shaposhnyk <mshaposh@redhat.com>
mshaposhnik
changed the title
hugares
reviewed
Nov 7, 2024
ifireball
reviewed
Nov 10, 2024
Member
ifireball
left a comment
ifireball
left a comment
There was a problem hiding this comment.
I'm trying to understand what would be the downside of doing this. Worst case - if we need to reconcile a task that is not in the cache, then we end up with slower reconciliation for it?
Member
|
To further improve memory usage, we can also consider using TransformFunc to trim resources before storing them in the cache. Like removing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have OOMs on prod, with mpc container consuming over 8Gb RAM. This is supposedly due ti high number of TaskRuns on cluster (>10000, and we cache them all)
This PR limits caches TRs to just those belonging to MPC
Possibe fix for https://issues.redhat.com/browse/KFLUXINFRA-887