Skip to content

Update heap logging to emit start/before gc/after gc/end events #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vlasakm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update heap logging to emit start/before gc/after gc/end events #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/bytecode/heap.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,23 @@ macro_rules! heap_log {
write!(file, "{},S,0\n", timestamp).unwrap();
}
};
(ALLOCATE -> $file:expr, $memory:expr) => {
(BEFORE_GC -> $file:expr, $memory:expr) => {
if let Some(file) = &mut $file {
let timestamp =
SystemTime::now().duration_since(SystemTime::UNIX_EPOCH).unwrap().as_nanos();
write!(file, "{},B,{}\n", timestamp, $memory).unwrap();
}
};
(AFTER_GC -> $file:expr, $memory:expr) => {
if let Some(file) = &mut $file {
let timestamp = SystemTime::now().duration_since(SystemTime::UNIX_EPOCH).unwrap().as_nanos();
write!(file, "{},A,{}\n", timestamp, $memory).unwrap();
}
};
(GC -> $file:expr, $memory:expr) => {
(END -> $file:expr, $memory:expr) => {
if let Some(file) = &mut $file {
let timestamp = SystemTime::now().duration_since(SystemTime::UNIX_EPOCH).unwrap().as_nanos();
write!(file, "{},G,{}\n", timestamp, $memory).unwrap();
write!(file, "{},E,{}\n", timestamp, $memory).unwrap();
}
}
}
Expand Down Expand Up @@ -62,7 +69,6 @@ impl Heap {
}
pub fn allocate(&mut self, object: HeapObject) -> HeapIndex {
self.size += object.size();
heap_log!(ALLOCATE -> self.log, self.size);
let index = HeapIndex::from(self.memory.len());
self.memory.push(object);
index
Expand All @@ -79,6 +85,12 @@ impl Heap {
}
}

impl Drop for Heap {
fn drop(&mut self) {
heap_log!(END -> self.log, self.size);
}
}

impl From<Vec<HeapObject>> for Heap {
fn from(objects: Vec<HeapObject>) -> Self {
Heap {
Expand Down Expand Up @@ -529,4 +541,4 @@ impl std::fmt::Display for Pointer {
Pointer::Reference(p) => write!(f, "{}", p),
}
}
}
}