React to combinations of greeting and acquaintance in single message #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 AI-Powered Solution
This pull request implements support for detecting and responding to messages that combine both a greeting and an acquaintance question in a single message.
📋 Issue Reference
Fixes #15
🎯 Problem
Previously, the bot had separate triggers for:
However, when users sent combined messages like "Привет! Мы знакомы?", neither trigger would fire because each trigger expected the ENTIRE message to match only its pattern (using
^and$anchors).✅ Solution
Created a new
GreetingAndAcquaintanceTriggerthat:📝 Implementation Details
New Files:
triggers/greeting-and-acquaintance.js- Main trigger implementation__tests__/triggers/greeting-and-acquaintance.js- Comprehensive test suite (18 tests, all passing)Modified Files:
triggers/acquaintance.js- ExportedacquaintedRegexfor potential reuseKey Features:
🧪 Test Results
This PR was created automatically by the AI issue solver