Conversation
|
Hey |
|
I unblocked the CI run, please take a look at the problems |
undera
left a comment
undera
left a comment
There was a problem hiding this comment.
Impressive work! A bit hard to review as single PR though.
Please clean up the unintentionally added files.
Also CI lint check fails, please address that.
There was a problem hiding this comment.
Please remove this file from Git
| github.com/crossplane-contrib/provider-kubernetes v0.9.0 | ||
| github.com/crossplane/crossplane v1.13.0 | ||
| github.com/crossplane/crossplane-runtime v0.20.0 | ||
| github.com/crossplane/crossplane v1.21.0-rc.0 |
There was a problem hiding this comment.
IMO depending on RC versions is not good. Is there a stable release to depend on?
There was a problem hiding this comment.
We have top-level go.mod file. Why do we need to introduce this one?
There was a problem hiding this comment.
THe whole folder of coverage should be removed, as it is dynamic and not part of codebase. Please use appropriate git config exclude to avoid committing these dynamic files.
There was a problem hiding this comment.
Why do we need this folder? Can't this test live in some other place?
There was a problem hiding this comment.
Please remove/exclude this file
| if err != nil { | ||
| return err | ||
| log.Debugf("Resource not found without namespace, trying common namespaces for %s", ref.Name) | ||
| namespacesToTry := []string{"vela-app-dev", "default", "crossplane-system", "upbound-system", "kube-system", "vela-system", "flux-system", "argocd", "argo-cd"} |
There was a problem hiding this comment.
Is it perhaps possible to paramaterise this list of namespaces (maybe even as a helm input)?
XRs are likley to be provisioned in tenant namespaces which are impossible to predict, especially with the gradual deprecation of claims
3 participants
This pull request introduces several improvements and enhancements to the backend, focusing on Crossplane CRD handling, API route expansion, dependency updates, and developer tooling. The most notable changes include more robust and version-aware handling of Crossplane CRDs, expanded API endpoints for better resource access, and improved test coverage for CRD listing logic.
Crossplane CRD Handling Improvements:
crdClientto support a version-aware XRD client, improving reliability when resolving plural resource names and handling different Crossplane versions. Added extensive debug logging throughout CRD operations for easier troubleshooting. [1] [2] [3] [4]ExtensionsV1Clientto attempt using a v2-compatible XRD client with a fallback to the original implementation, making the client more robust to Crossplane API changes. [1] [2]API Route Expansion:
/composition/:nameendpoint for retrieving individual compositions.Testing and Quality Assurance:
Listmethod, covering all-namespaces queries, error handling, and invalid JSON scenarios, ensuring correct CRD listing behavior.Dependency and Tooling Updates:
.vscode/settings.jsonfor improved developer experience with recommended extensions and workspace settings.Makefilewith new targets for backend/frontend tests, coverage, and quality checks, and improved help output.Minor Improvements: