refactor: Refactor client to meet the needs of the implementation to be performed

[juanhiginio]

Context

Refactor client to meet the needs of the implementation to be performed, leaving endpoint for business_key validation but without making it a requirement to validate it when wanting to create an instance of a process, since this validation will be done by the implementation before making the request to the process instance creation endpoint.

Summary by CodeRabbit

• Refactor
  • Streamlined the process instance start functionality by removing business key uniqueness validation.

[coderabbitai]

Walkthrough

The ProcessClient class's method for starting a process instance was simplified by removing the uniqueness validation for business keys. The method signature was updated, and the internal validation logic was deleted, resulting in direct process instance creation without checking for existing business keys.

Changes

File	Change Summary
lib/bas/utils/operaton/process_client.rb	Removed validate_business_key parameter and uniqueness check from start_process_instance_by_key; deleted validate_uniqueness! method; updated instance_with_business_key_exists? to check only active instances.
spec/bas/operaton/process_client_spec.rb	Removed tests and stubs related to business key uniqueness validation in start_process_instance_by_key.

Possibly related PRs

• feat: Implement client to perform process deployments and instance creation in Operaton via the REST API #146: Introduced the ProcessClient with business key uniqueness validation, which this PR now removes from the same methods and class.

Poem

A hop and a skip, the checks are gone,
No more uniqueness to dwell upon.
Now process keys start with glee,
Unburdened, simpler—so it shall be!
The code is lighter, the flow is spry,
A rabbit’s nod, as changes fly. 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dca4462 and 2bae1a8.

📒 Files selected for processing (2)

• lib/bas/utils/operaton/process_client.rb (1 hunks)
• spec/bas/operaton/process_client_spec.rb (0 hunks)

💤 Files with no reviewable changes (1)

• spec/bas/operaton/process_client_spec.rb

🚧 Files skipped from review as they are similar to previous changes (1)

• lib/bas/utils/operaton/process_client.rb

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coveralls]

Pull Request Test Coverage Report for Build 16306838529

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.02%) to 98.153%

---

Totals
Change from base Build 16298039184:	-0.02%
Covered Lines:	1701
Relevant Lines:	1733

---

💛 - Coveralls