HW #2 #5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # AGENTS.md | ||
|
|
||
| ## Purpose | ||
|
|
||
| Guidance for AI coding agents working in this repository. Follow these rules unless a human explicitly overrides them. | ||
|
|
||
| ## Architecture Constraints | ||
|
|
||
| - Use custom state management via `actionManager`; do not introduce Redux, Zustand, or MobX. | ||
| - Perform state updates through `actionManager.dispatch()` only. | ||
| - Keep core app state aligned with `AppState` in `src/types.ts`. | ||
| - Use Canvas 2D for drawing/rendering flows; do not replace with React DOM drawing. | ||
| - Preserve render flow: `Scene -> renderScene() -> canvas context`. | ||
| - Do not introduce `react-konva`, `fabric.js`, or `pixi.js`. | ||
| - Do not add new npm dependencies without explicit approval. | ||
| - Check existing utilities (for example `src/utils/`) before adding external helpers. | ||
|
|
||
| ## Code Conventions | ||
|
|
||
| - Use functional components with hooks only; avoid class components. | ||
| - Prefer named exports over default exports. | ||
| - Keep TypeScript strict; avoid `any` and `@ts-ignore`. | ||
| - Prefer `type` over `interface` for simple types. | ||
| - Use `import type { X } from "..."` for type-only imports. | ||
| - Use `kebab-case` for utility file names and `PascalCase` for component files. | ||
| - Keep tests colocated where practical (for example `ComponentName.test.tsx`). | ||
|
|
||
| ## Protected Files | ||
|
|
||
| Do not modify the following files without explicit human approval: | ||
|
|
||
| - `src/core/renderer.ts` (render pipeline) | ||
| - `src/data/restore.ts` (file format compatibility) | ||
| - `src/actions/manager.ts` (action dispatch system) | ||
| - `src/types.ts` (core type definitions) | ||
|
|
||
| If protected files must change, require: | ||
|
|
||
| 1. Understanding of dependencies and downstream impact. | ||
| 2. Running the relevant test suite. | ||
| 3. Manual verification of behavior. | ||
|
|
||
| ## Working Style | ||
|
|
||
| - Make focused, minimal changes. | ||
| - Do not refactor unrelated code. | ||
| - Preserve existing behavior unless asked to change it. | ||
| - Flag uncertainty and assumptions in your final update. | ||
|
Comment on lines
+1
to
+48
There was a problem hiding this comment. ❌ Файл не відповідає вимогам завдання — бракує обов'язкових секцій Згідно з вимогами до Відсутні критичні секції:
Наявні секції:
Додатково добре:
📋 Приклад структури для відсутніх секційДодайте після секції Purpose: ## Purpose
Guidance for AI coding agents working in this repository. Follow these rules unless a human explicitly overrides them.
+## Project Overview
+
+Excalidraw is an open-source virtual whiteboard for sketching hand-drawn like diagrams. It supports collaborative editing, export to PNG/SVG, and local-first architecture with optional cloud sync. Built as a React-based canvas editor with a focus on simplicity and user experience.
+
+## Tech Stack
+
+- **Frontend**: React 18+ with TypeScript
+- **Build Tool**: Vite
+- **Package Manager**: Yarn (workspaces enabled)
+- **Testing**: Vitest, React Testing Library
+- **Rendering**: Canvas 2D API
+
+## Project Structure
+
+Monorepo layout:
+- `packages/excalidraw/` — core library (canvas, actions, state)
+- `excalidraw-app/` — web application wrapper
+- `src/` — main source directory (components, actions, utils, types)
+- `src/tests/` — integration and unit tests
+
+## Key Commands
+
+- `yarn install` — install dependencies
+- `yarn start` — dev server (excalidraw-app)
+- `yarn build` — production build
+- `yarn test` — run Vitest suite
+- `yarn test:watch` — watch mode
+- `yarn typecheck` — TypeScript validation
+
## Architecture Constraints🤖 Prompt for AI Agents |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| # ONBOARDING | ||
|
|
||
| ## Purpose | ||
|
|
||
| This guide helps new contributors (human and AI) work safely in this repository with consistent project rules and Cursor commands. | ||
|
|
||
| ## Repository Guidance Files | ||
|
|
||
| - `AGENTS.md`: repo-wide operating guidance for AI agents. | ||
| - `.cursor/rules/*.mdc`: focused, persistent rules that apply by scope (`globs`) or globally (`alwaysApply`). | ||
| - `.cursor/commands/*.md`: reusable slash commands for common workflows. | ||
|
|
||
| ## Quick Start | ||
|
|
||
| 1. Read `README.md` for project setup and architecture context. | ||
| 2. Read `AGENTS.md` before making code changes. | ||
| 3. Review relevant rule files in `.cursor/rules/`. | ||
| 4. Use commands in `.cursor/commands/` for consistent execution and review. | ||
| 5. Keep changes minimal, test behavior changes, and document assumptions. | ||
|
|
||
| ## Current Cursor Rules | ||
|
|
||
| - `architecture.mdc`: architecture constraints for project structure and dependencies. | ||
| - `conventions.mdc`: code conventions for TypeScript/components. | ||
| - `do-not-touch.mdc`: protected files and restrictions. | ||
| - `action-manager-state.mdc`: state updates must go through `actionManager.dispatch()`. | ||
| - `canvas-rendering.mdc`: rendering must remain on Canvas 2D pipeline. | ||
| - `typescript-safety.mdc`: strict typing and type import conventions. | ||
| - `module-boundaries.mdc`: package boundaries and utility reuse guidance. | ||
| - `testing-requirements.mdc`: tests required for behavior changes. | ||
| - `change-scope.mdc`: keep changes focused and minimal. | ||
|
|
||
| ## Rule Usage Notes | ||
|
|
||
| - Rule scope is controlled by front-matter: | ||
| - `globs`: where a rule applies (for example `packages/**/*.ts`). | ||
| - `alwaysApply`: if `true`, rule applies in every session. | ||
| - Keep rules concise and actionable. | ||
| - Include a `How to verify` section in rule content for consistency. | ||
|
|
||
| ## Current Cursor Commands | ||
|
|
||
| - `rules-check.md` -> `/rules-check` | ||
| - Reviews changes against `AGENTS.md` and all `.cursor/rules/*.mdc`. | ||
| - Returns violations, risk level, and a compliance checklist. | ||
| - `implement-safe.md` -> `/implement-safe` | ||
| - Implements a request with minimal changes while enforcing repository rules. | ||
| - Accepts user prompt via `$ARGUMENTS`. | ||
|
|
||
| ## Recommended Workflow | ||
|
|
||
| 1. Start with `/implement-safe <your task>`. | ||
| 2. Apply the smallest correct change. | ||
| 3. Add/update tests for behavior changes. | ||
| 4. Run `/rules-check` before finalizing. | ||
|
|
||
| ## Protected File Reminder | ||
|
|
||
| Certain files are protected by policy in `do-not-touch.mdc` and `AGENTS.md`. Any change to protected/core files requires explicit approval plus stronger verification. | ||
|
|
||
| ## Maintenance | ||
|
|
||
| - When adding new `.cursor/rules` files, update this document. | ||
| - When adding new `.cursor/commands`, add usage notes here. | ||
| - Keep examples and paths aligned with the current monorepo layout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,124 +1,42 @@ | ||
| # Cursor Rules | ||
|
|
||
| This folder is for Cursor rule files (e.g. `RULE.md`) that provide persistent AI guidance within this repository. | ||
|
|
||
| ## Pull Request Placement Rule | ||
|
|
||
| - Any Cursor-related files included in a Pull Request must be placed under `.cursor/`. | ||
| - Rule files must go in `.cursor/rules/`. | ||
| - Command files must go in `.cursor/commands/`. | ||
|
|
||
| ## What Goes In `.cursor/rules/` | ||
|
|
||
| - Files with `.mdc` extension only. | ||
| - Persistent project guidance and constraints for AI. | ||
| - Rules that define architecture, coding conventions, safety limits, testing expectations, and protected files. | ||
| - Rules should use front-matter fields such as `description`, `globs`, and `alwaysApply`. | ||
| - Examples: | ||
| - `architecture.mdc` | ||
| - `conventions.mdc` | ||
| - `do-not-touch.mdc` | ||
| - `module-boundaries.mdc` | ||
| - `change-scope.mdc` | ||
| - `canvas-rendering.mdc` | ||
| - `action-manager-state.mdc` | ||
| - `typescript-safety.mdc` | ||
| - `testing-requirements.mdc` | ||
|
|
||
| ## What Goes In `.cursor/commands/` | ||
|
|
||
| - Files with `.md` extension only. | ||
| - Reusable slash command prompts the team can run in Cursor. | ||
| - Commands that describe task workflows (for example: implement safely, run compliance review, prepare PR checks). | ||
| - Commands can include `$ARGUMENTS` placeholders for user input. | ||
| - Examples: | ||
| - `rules-check.md` -> `/rules-check` | ||
| - `implement-safe.md` -> `/implement-safe` | ||
|
|
||
| ## Do Not Mix These | ||
|
|
||
| - Do not put command prompts in `.cursor/rules/`. | ||
| - Do not put `.mdc` rule definitions in `.cursor/commands/`. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| --- | ||
| description: State updates must go through actionManager | ||
| globs: packages/**/*.ts,packages/**/*.tsx | ||
| alwaysApply: false | ||
| --- | ||
|
|
||
| # State Updates Through actionManager | ||
|
|
||
| - Use project state managed by `actionManager`. | ||
| - Do not introduce Redux, Zustand, MobX, or ad-hoc global stores. | ||
| - Route state changes via `actionManager.dispatch()` only. | ||
| - Keep state shape compatible with `AppState`. | ||
|
|
||
| ## How to verify | ||
|
|
||
| - Search changed files for direct state mutation patterns. | ||
| - Confirm new state-changing code calls `actionManager.dispatch()`. | ||
| - Confirm no new third-party state manager dependency was added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| --- | ||
| description: Architecture constraints for the project | ||
| globs: src/** | ||
| alwaysApply: false | ||
| --- | ||
|
|
||
| # Project Architecture | ||
|
|
||
| ## State Management | ||
|
|
||
| - Custom state via actionManager — NOT Redux/Zustand/MobX | ||
| - State updates: actionManager.dispatch() ONLY | ||
| - State type: AppState (src/types.ts) | ||
|
|
||
| ## Rendering | ||
|
|
||
| - Canvas 2D rendering — NOT React DOM for drawing | ||
| - Render pipeline: Scene → renderScene() → canvas context | ||
| - DO NOT use react-konva, fabric.js, pixi.js | ||
|
|
||
| ## Dependencies | ||
|
|
||
| - No new npm packages without explicit approval | ||
| - Check src/utils/ before adding external helpers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| --- | ||
| description: Keep rendering on Canvas 2D pipeline | ||
| globs: packages/**/*.ts,packages/**/*.tsx | ||
| alwaysApply: false | ||
| --- | ||
|
|
||
| # Canvas Rendering Pipeline | ||
|
|
||
| - Use Canvas 2D rendering for drawing operations. | ||
| - Preserve render flow: `Scene -> renderScene() -> canvas context`. | ||
| - Do not switch drawing to React DOM. | ||
| - Do not introduce `react-konva`, `fabric.js`, or `pixi.js`. | ||
|
|
||
| ## How to verify | ||
|
|
||
| - Review rendering changes for canvas context usage. | ||
| - Confirm no JSX/DOM drawing replacement was added. | ||
| - Check `package.json` diff for prohibited rendering dependencies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| --- | ||
| description: Keep changes minimal and task-focused | ||
| alwaysApply: true | ||
| --- | ||
|
|
||
| # Change Scope Discipline | ||
|
|
||
| - Make the smallest change that solves the requested task. | ||
| - Avoid broad refactors unless explicitly requested. | ||
| - Do not modify protected/core files without explicit approval. | ||
| - Call out assumptions and risks when requirements are ambiguous. | ||
|
|
||
| ## How to verify | ||
|
|
||
| - Review diff for unrelated file churn and remove it. | ||
| - Confirm changes map directly to the user request. | ||
| - Ensure any protected-file edits have explicit approval recorded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| --- | ||
| alwaysApply: true | ||
| --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| --- | ||
| alwaysApply: true | ||
| --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| Implement the request below with minimal, task-focused edits while following `AGENTS.md` and `.cursor/rules/*.mdc`. | ||
|
|
||
| Request: | ||
| $ARGUMENTS | ||
|
|
||
| Execution requirements: | ||
| - make the smallest correct change | ||
| - avoid unrelated refactors | ||
| - do not add new dependencies without explicit approval | ||
| - do not modify protected files without explicit approval | ||
| - update or add tests when behavior changes | ||
|
|
||
| Before finishing, provide: | ||
| 1. files changed | ||
| 2. what was verified (tests/lint/typecheck/manual) | ||
| 3. assumptions or follow-ups |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| --- | ||
| description: Respect package boundaries and reuse existing utilities | ||
| globs: packages/**/*.ts,packages/**/*.tsx | ||
| alwaysApply: false | ||
| --- | ||
|
|
||
| # Module Boundaries | ||
|
|
||
| - Reuse existing helpers before creating new utility modules. | ||
| - Keep imports scoped to intended package APIs where possible. | ||
| - Avoid circular dependencies across packages. | ||
| - Keep feature changes localized; do not restructure unrelated modules. | ||
|
|
||
| ## How to verify | ||
|
|
||
| - Review import graph in changed files for new cross-package coupling. | ||
| - Confirm no duplicate utility logic was added when equivalents exist. | ||
| - Check for newly introduced circular import warnings/errors. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Наразі описано лише обмеження (constraints), але відсутній огляд основних компонентів системи. За вимогами, Architecture секція має включати:
Поточний вміст — це радше "Architecture Prohibitions", а не повноцінний архітектурний огляд.
♻️ Рекомендація: розширити до Architecture
Перейменуйте та доповніть секцію:
📝 Committable suggestion
🤖 Prompt for AI Agents