Skip to content

onboarding documentation for Excalidraw project#13

Open
artemkozachenko-inv wants to merge 2 commits intokoldovsky:mainfrom
artemkozachenko-inv:main
Open

onboarding documentation for Excalidraw project#13
artemkozachenko-inv wants to merge 2 commits intokoldovsky:mainfrom
artemkozachenko-inv:main

Conversation

@artemkozachenko-inv
Copy link
Copy Markdown

@artemkozachenko-inv artemkozachenko-inv commented Mar 21, 2026

Summary by CodeRabbit

  • Documentation
    • Added a comprehensive engineer onboarding guide covering product overview, repository layout, development setup and scripts, architecture and rendering concepts, collaboration and persistence patterns, testing and build workflows, common contribution tasks, a “where to find things” map, glossary, and links to further resources.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bce0546e-f3b1-4e02-8b12-5cd362002c01

📥 Commits

Reviewing files that changed from the base of the PR and between f03a2d7 and 38f513e.

📒 Files selected for processing (1)
  • ONBOARDING.md
✅ Files skipped from review due to trivial changes (1)
  • ONBOARDING.md

📝 Walkthrough

Walkthrough

Added ONBOARDING.md, a comprehensive engineer onboarding guide for the Excalidraw monorepo covering repo layout, toolchain and environment setup, package dependency rules, core architecture (action system, dual Jotai stores, rendering pipeline, reconciliation), persistence, testing, build flows, and common developer workflows.

Changes

Cohort / File(s) Summary
Developer Onboarding Documentation
ONBOARDING.md
New 751-line onboarding guide added. Documents monorepo structure, toolchain expectations (Yarn workspaces, TypeScript, Vite, esbuild, Vitest, React, Jotai), package layering, development setup and scripts, action/event system, dual Jotai stores, delta undo/redo, dual-canvas rendering, reconciliation rules, persistence/storage, testing guidance, build workflows, and onboarding resources.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 In a burrow of docs, I hopped with delight,

Pages of guidance now glowing so bright.
Paths through the code and the tools all in view,
Welcome, new dev — we’ve prepared this for you. 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'onboarding documentation for Excalidraw project' directly and accurately describes the main change: adding comprehensive onboarding documentation (ONBOARDING.md file) to the Excalidraw project.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.

Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
ONBOARDING.md (1)

582-582: Use spaced unit formatting for readability.

Line 582: prefer 300 ms instead of 300ms for consistent technical writing style.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@ONBOARDING.md` at line 582, Update the phrasing in the ONBOARDING.md sentence
that references LocalData.ts to use spaced unit formatting: change "300ms" to
"300 ms" so the write strategy description reads that saves occur at most once
per 300 ms; keep the rest of the sentence unchanged and ensure the file
reference LocalData.ts remains intact.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@ONBOARDING.md`:
- Around line 45-68: Update the fenced code blocks in ONBOARDING.md to include
explicit language identifiers (e.g., use ```text) so markdownlint MD040 warnings
are resolved; specifically replace the unlabeled triple-backtick blocks that
render the repository tree and package/src listings (examples include the
excalidraw-master/ tree and the packages/common/src/, packages/math/src/,
packages/element/src/, packages/utils/src/ blocks) and any other unlabeled
blocks at the mentioned ranges (185-194, 204-213, 221-239, 308-314, 476-491)
with labeled fences like ```text to ensure consistent rendering and lint
compliance.

---

Nitpick comments:
In `@ONBOARDING.md`:
- Line 582: Update the phrasing in the ONBOARDING.md sentence that references
LocalData.ts to use spaced unit formatting: change "300ms" to "300 ms" so the
write strategy description reads that saves occur at most once per 300 ms; keep
the rest of the sentence unchanged and ensure the file reference LocalData.ts
remains intact.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: df37bf00-4577-4383-b1df-d11f24895ac9

📥 Commits

Reviewing files that changed from the base of the PR and between be47f1d and f03a2d7.

📒 Files selected for processing (1)
  • ONBOARDING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants