Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions PathOfBuilding.app/Contents/Resources/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleVersion</key>
<string>0.1.2</string>
<string>0.1.3</string>
<key>CFBundleShortVersionString</key>
<string>0.1.2</string>
<string>0.1.3</string>
</dict>
</plist>
15 changes: 15 additions & 0 deletions PathOfBuilding.app/Contents/Resources/changelog.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
VERSION[0.7.0][2026/02/21]

--- 新機能 / New Features ---
* パッシブツリー翻訳をi18nシステムに統合(TreeTranslations廃止)
* ja_passive_names.lua: 1911件のノード名翻訳を新規i18n補助ファイルとして抽出
* ja_mod_stat_lines.lua: 1077件の新規stat行テンプレートを追加
* 複数行stat結合ロジック追加(改行分割されたstat行を自動結合して翻訳)
* ノード名末尾空白トリム対応(5件8ノード)
* Attribute/Attributesノード名翻訳追加(296ノード)

--- バグ修正 / Bug Fixes ---
* 49件のハードコード数値をプレースホルダ形式に修正(翻訳テンプレート品質向上)
* "A maximum of one Modifer"の誤翻訳を修正
* multi-line stat結合時の消費行表示を修正(空行表示防止)

VERSION[0.6.0][2026/02/21]

--- 新機能 / New Features ---
Expand Down
12 changes: 12 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,18 @@ Whether this macOS port can keep up with the PoE2 0.5 update from the upstream P

## バージョン履歴 / Version History

### v0.7.0 (2026-02-21)

- パッシブツリー翻訳をi18nシステムに統合(TreeTranslations/ja.lua廃止→i18n補助ファイル一本化)
- 1911件のノード名翻訳 + 1077件の新規stat行テンプレートを追加
- 複数行stat結合ロジック・ノード名末尾空白トリム・翻訳テンプレート品質修正

---

- Integrated passive tree translations into i18n system (removed standalone TreeTranslations/ja.lua)
- Added 1911 node name translations + 1077 new stat line templates
- Multi-line stat combining logic, node name whitespace trimming, template quality fixes

### v0.6.0 (2026-02-21)

- スキルジェムツールチップの日本語翻訳を大幅強化(効果分岐ラベル約360件追加)
Expand Down
100 changes: 100 additions & 0 deletions skills/ship-feature.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,100 @@
---
name: ship-feature
description: Commit, PR, review, fix, merge, and cleanup a feature branch. Use when implementation is done and ready to ship.
---

# Ship Feature

Full workflow to ship a completed feature branch: commit, PR, review, fix, merge, cleanup.

**Prerequisites:** Implementation is complete and on a feature branch (not `main`).

## Step 1: Commit

Stage relevant files and create a commit. Commit messages must be in Japanese with a conventional prefix (`feat:`, `fix:`, `chore:`, `refactor:`, etc.).

```bash
git add <files>
git commit -m "feat: パッシブツリー翻訳をi18nシステムに統合"
```

- Use `git diff` and `git status` to understand what changed before writing the message.
- Be specific in the message body about what was done and why.

## Step 2: Push and Create PR

Push the branch and create a PR on the **fork** repo. The `--repo` flag is required because the upstream remote points to `PathOfBuildingCommunity`.

```bash
git push -u origin <branch-name>

gh pr create --repo kokagex/PoB2-for-macOS --base main \
--title "<Japanese title matching commit convention>" \
--body "$(cat <<'EOF'
## Summary
- <1-3 bullet points describing the change>

## Changes
- `file1.lua`: <what changed>
- `file2.lua`: <what changed>

## Test plan
- [ ] <manual verification step>
- [ ] <manual verification step>

🤖 Generated with [Claude Code](https://claude.com/claude-code)
EOF
)"
```

- PR title should match the main commit message style (Japanese, prefixed).
- The body uses the repo's standard template: **Summary**, **Changes** (per-file), **Test plan** (checklist).

## Step 3: Code Review

Dispatch the `superpowers:code-reviewer` subagent to review the PR diff.

```bash
BASE_SHA=$(git merge-base origin/main HEAD)
HEAD_SHA=$(git rev-parse HEAD)
```

Provide the code-reviewer with:
- What was implemented
- The plan or requirements it should satisfy
- BASE_SHA and HEAD_SHA
- Brief description

Wait for findings. Findings are categorized:
- **Critical** — Must fix before merge
- **Important** — Must fix before merge
- **Suggestion/Minor** — Optional, fix at your discretion

## Step 4: Fix Review Findings

Address all Critical and Important findings:

1. Make the fixes
2. Stage and commit: `git commit -m "fix: コードレビュー指摘対応(C1, C2, I1)"`
3. Push: `git push`

If there are only Suggestion-level findings, you may skip this step.

## Step 5: Merge PR

```bash
gh pr merge <PR-NUMBER> --repo kokagex/PoB2-for-macOS --merge --delete-branch
```

- Uses merge commit strategy (not squash or rebase).
- `--delete-branch` removes the remote branch after merge.

## Step 6: Cleanup

Switch back to main and sync:

```bash
git checkout main && git pull origin main && git branch -d <branch-name>
```

This deletes the local feature branch and ensures main is up to date.