Sync 24 upstream data files with PoE2 dev branch#11
Merged
kokagex merged 5 commits intopob2macos_stage2from Feb 19, 2026
Merged
Sync 24 upstream data files with PoE2 dev branch#11kokagex merged 5 commits intopob2macos_stage2from
kokagex merged 5 commits intopob2macos_stage2from
Conversation
Replace all high-priority data files with upstream versions: StatDescriptions (5 files): Updated mod/skill/gem descriptions ModCache.lua: Refreshed mod parsing cache (+11.8k/-4k lines) Bases (6 files): Updated weapon bases, removed DNT placeholders, added flail/dagger entries Uniques (2 files): New uniques, removed PoE1 race items Global.lua: Added KeywordFlag.Arrow (required by synced calc engine) SkillStatMap.lua: Arrow keyword integration Minions.lua: Updated weapon types to PoE2 naming Spectres.lua: Updated spectre data Misc.lua: Updated constants (removes local metatable guards) TimelessJewelData (2 files): Updated legion/node data Gems.lua, ModScalability.lua, ModItemExclusive.lua: Minor updates Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Move setmetatable safety guards for characterConstants/monsterConstants
from Misc.lua to Data.lua (survives future data syncs)
- Update weaponTypeInfo to PoE2 naming ("One Hand" format) with
Warstaff and Quarterstaff label, keep legacy "One Handed" aliases
for backward compatibility with TradeQuery/locale files
- Update unarmedWeaponData to PoE2 classes (Ranger, Huntress, Warrior,
Mercenary, Druid, Witch, Sorceress, Monk) with correct CritChance
from characterConstants
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ypes Upstream ModParser.lua (synced in Phase 1) creates mod value tables with mixed key types (string "mod" + numeric [1]), but local ModTools.lua used plain table.sort which crashes when comparing strings with numbers. Adds upstream's custom comparator to both formatTag and formatValue. Fixes launch crash: "attempt to compare string with number" triggered by Blackened Heart ascendancy node processing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move 24 data files from "Not Synced" to "Synced" section under Phase 2. Document compatibility fixes (Data.lua metatable guards, ModTools.lua sort comparator). Note formatTag comparator as local defensive addition. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PathOfBuildingCommunity/PathOfBuilding-PoE2dev branchCompatibility fixes in Data.lua
weaponTypeInfoto PoE2 naming ("One Hand Axe" etc.) with legacy aliases ("One Handed Axe")unarmedWeaponDatato PoE2 classes (Ranger, Huntress, Warrior, Mercenary, Druid, Witch, Sorceress, Monk)Test plan
🤖 Generated with Claude Code