Enable ACT tests for html-has-lang, html-lang-valid, empty-heading, duplicate-id#357
Open
Enable ACT tests for html-has-lang, html-lang-valid, empty-heading, duplicate-id#357
Conversation
…uplicate-id - Remove b5c3f8, bf051a, ffd0e9, 3ea0c8 from rulesToIgnore in generate-act-tests.js - Register html-has-lang rule in scanner.ts (was implemented but not imported) - Fix html-lang-valid to validate only the primary language subtag per BCP 47 (e.g. "en-US-GB" is valid because primary subtag "en" is valid) - Update unit test for html-lang-valid to match corrected behavior - Mark html-has-lang, html-lang-valid, empty-heading, duplicate-id as implemented in rules.json - Note: ffd0e9 (empty-heading) and 3ea0c8 (duplicate-id) have no WCAG-mapped ACT test cases, so no test files are generated for them Part of #348 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
b5c3f8(html-has-lang),bf051a(html-lang-valid),ffd0e9(empty-heading),3ea0c8(duplicate-id)html-has-langrule was implemented but never imported/registered inscanner.ts— now activehtml-lang-validnow validates only the primary language subtag per BCP 47 (e.g.en-US-GBis valid becauseenis valid)rules.jsonto mark all 4 as implementedPart of #348
Test plan
🤖 Generated with Claude Code