Fix cross-rule interference in ACT tests#353
Merged
Conversation
For "passed" ACT tests where no scanner rule maps to the ACT rule being tested, the generated assertion now trivially passes instead of checking that all scan results are empty. This prevents unrelated rules (e.g. document-title) from causing false failures on tests focused on other rules. Removes 3 qt1vmo test URLs from ignoredExamples that were skipped due to cross-rule interference, since they now generate correctly scoped assertions. Fixes #349 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expectedUrlsis empty (no scanner rule maps to the ACT rule), the generated assertion now usesexpect([]).to.be.emptyto avoid false negatives from unrelated rules firingqt1vmo(image-alt) test cases that were ignored due todocument-titlecross-rule interferenceFixes #349
Test plan
🤖 Generated with Claude Code