Filter ACT test results in generator to only check the rule under test#342
Merged
Filter ACT test results in generator to only check the rule under test#342
Conversation
koddsson
force-pushed
the
fix/334-act-test-filtering
branch
from
af14f33 to
bee0e93
Compare
koddsson
force-pushed
the
fix/334-act-test-filtering
branch
from
bee0e93 to
c6b5c84
Compare
For "passed" tests, filter scan results to only include violations from the scanner rule that maps to the ACT rule being tested. This prevents unrelated rules (e.g. document-title, aria-dialog-name) from causing false failures on tests focused on other rules. The fix is in generate-act-tests.js so it survives regeneration, rather than patching individual generated test files. Also adds rm cleanup of stale test files before regeneration, and excludes tests that can't work in this environment (Shadow DOM script execution, cross-rule interference without URL mapping). Fixes #334 Fixes #336 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
koddsson
force-pushed
the
fix/334-act-test-filtering
branch
from
c6b5c84 to
6a71966
Compare
The generator now rm's the test directory before regenerating, which wiped manually-added .skip annotations. Add a skippedExamples list that generates it.skip instead of it for 26 tests across bc659a, bisz58, c487ae, and de46e4 rules where the scanner lacks the needed checks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate-act-tests.jsto filter "passed" test results to only include violations from the scanner rule mapped to the ACT rule being testedactRuleIdToExpectedUrlsmapping (fromrules.json) to determine which scanner rule URLs are relevantCloses #334
Closes #336
Test plan
🤖 Generated with Claude Code