Compatibility with new versions of asmjit#19
Closed
MatteoCaldana wants to merge 3 commits intokobalicek:masterfrom
Closed
Compatibility with new versions of asmjit#19MatteoCaldana wants to merge 3 commits intokobalicek:masterfrom
MatteoCaldana wants to merge 3 commits intokobalicek:masterfrom
Conversation
kobalicek
reviewed
Jun 14, 2025
Owner
kobalicek
left a comment
kobalicek
left a comment
There was a problem hiding this comment.
Almost all good, thanks, only that one little comment
src/mathpresso/mathpresso_p.h
Outdated
| #include <asmjit/asmjit.h> | ||
| #include <asmjit/core.h> | ||
| #include <asmjit/x86.h> | ||
| #include <asmjit/a64.h> |
Owner
There was a problem hiding this comment.
Here only <asmjit/x86.h> should be included.
Author
There was a problem hiding this comment.
Thanks! I’ve applied the fix
Owner
|
@MatteoCaldana I had to do a little bit more changes because of the latest AsmJit update, I have incorporated your changes and did mine, so I'm closing this - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a breaking change on the new API of asmjit of the functions
Fix a warning of the include of asmjit